This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Require MaxEncodedLen per default
#10662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
ggwpez
added
A3-in_progress
ggwpez
requested review from
acatangiu,
andresilva,
athei and
kianenigma
as code owners
github-actions
bot
added
A0-please_review
kianenigma
approved these changes
Jan 14, 2022
ggwpez
added
A3-in_progress
Member
Author
|
Thanks @kianenigma for the very fast review! |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
github-actions
bot
added
A0-please_review
ggwpez
added
A3-in_progress
shawntabrizi
added
the
D3-trivial 🧸
shawntabrizi
approved these changes
Jan 14, 2022
KiChjang
approved these changes
Jan 14, 2022
Contributor
KiChjang
left a comment
KiChjang
left a comment
There was a problem hiding this comment.
This is basically flipping the default to generating the full storage info instead of the partial one, which could now cause issues for devs downstream who were not aware of the MaxEncodedLen changes required to keep the PoV sizes measurable.
We'll need to properly announce this change in the proper channels so that they are all well-informed, because I can 100% foresee an influx of devs asking why their chains don't compile after updating substrate to the latest monthly version or so.
Member
Author
|
bot merge |
4 tasks
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Jan 31, 2022
14 tasks
26 tasks
jasl
added a commit
to Phala-Network/khala-parachain
that referenced
this pull request
Feb 6, 2022
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Feb 6, 2022
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Feb 6, 2022
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Feb 7, 2022
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Feb 7, 2022
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Feb 7, 2022
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Feb 7, 2022
jasl
added a commit
to Phala-Network/phala-blockchain
that referenced
this pull request
Feb 7, 2022
wischli
added a commit
to KILTprotocol/kilt-node
that referenced
this pull request
Feb 9, 2022
* chore: bump Polkadot dependencies to v0.9.16 * refactor: use AllPalletsWithSystem hook * chore: remove crowdloan pallet * fix: apply no DefaultAccount check * fix: switch to default MaxEncodedLen paritytech/substrate#10662 * fix: apply asset quota + runtime state_version quota: paritytech/substrate#10382 state: paritytech/substrate#9732 * fix: Preimage registrar and Scheduler integration Scheduler: paritytech/substrate#10356 OriginPriviligeCmp: paritytech/polkadot#4166 * fix: OrderedSet * fix: apply new fork_id to chainspecs paritytech/substrate#10463 * fix: apply no default account for SudoConfig * fix: apply name changes for GrandPa paritytech/substrate#10463 * fix: EnsureOneOf paritytech/substrate#10379 * fix: preimage weights * fix: parachain client * fix: clippy copied weights * fix: bump deps * tests: attempt staking fix * bench: attempt to fix default accountid for dids * fix: staking unit test pallet order execution * fix: did unit benchmarks * fix: fmt * fix: revert to old hook order execution * bench: run manually for preimage + scheduler * fix: only import TaskManager for try-runtime feature * fix: use correct scheduler migration + add logs * refactor: use explicit para runtime executors * fix: apply code review by @Diiaablo95 * chore: apply suggestion from @weichweich review * chore: bump deps * fix: deps
2 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Remove generate_storage_info Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add without_storage_info where needed Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update doc tests Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add more without_storage_info Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fix TryBuild Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fix TryBuild tests Signed-off-by: Oliver Tale-Yazdi <[email protected]>
1 task
9 tasks
aurexav
added a commit
to darwinia-network/darwinia-common
that referenced
this pull request
Sep 14, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Remove generate_storage_info Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add without_storage_info where needed Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update doc tests Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add more without_storage_info Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fix TryBuild Signed-off-by: Oliver Tale-Yazdi <[email protected]> * fix TryBuild tests Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without_storage_infowhich is required on all Pallets that do not implementMaxEncodedLengenerate_storage_infowhich is applied per defaultCloses #10652
Related paritytech/polkadot-sdk#323
Polkadot companion: paritytech/polkadot#4746
Cumulus companion: paritytech/cumulus#917