New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1494 JS error Optimizer empty terms selection #1495

Merged

romainruaud merged 1 commit into Smile-SA:2.8.x from rbayet:fix_optimizer_empty_terms_selection

Aug 2, 2019

Collaborator

rbayet commented Aug 2, 2019 •

edited

Loading

The fix obviously looks like a fix, there might be in the future a need of a rework or refactoring of

\Smile\ElasticsuiteCatalogOptimizer\Model\Optimizer\Limitation\ReadHandler
\Smile\ElasticsuiteCatalogOptimizer\Ui\Component\Optimizer\Form\Modifier\Limitation
\Smile\ElasticsuiteCatalogOptimizer\Ui\Component\Optimizer\Form\Modifier\SearchTerms

which have redundant and interdependent code.


          Fixes Smile-SA#1494 JS error Optimizer empty terms selection

fbbe27b

rbayet requested a review from romainruaud

August 2, 2019 10:24

rbayet assigned romainruaud

romainruaud merged commit f6c3903 into Smile-SA:2.8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet