Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic rows JS error in optimizer form with category limitation and no search terms #1494

Closed
rbayet opened this issue Aug 2, 2019 · 0 comments
Assignees
Labels

Comments

@rbayet
Copy link
Collaborator

rbayet commented Aug 2, 2019

When an optimizer is configured for both catalog and search containers and category limitations are configured, there is a javascript error produced when the form is re-opened after the form has been saved while the search terms limitation panel was left opened without any terms selected.

Preconditions

Magento Version : 2.3.0 EE, CE

ElasticSuite Version : 2.8.x-dev

Environment : Developer and Production

Third party modules : N/A

Steps to reproduce

  1. Create a new optimizer configured to be available in all three scopes, save and continue
  2. Add a category limitation, save and continue OR save and edit the optimizer again
  3. Start adding a search terms limitation, but do not select any search terms, so the " Catalog Product Search / Apply to" select is set on "Selected search terms" but with an empty selection
  4. Save and continue OR save and edit the optimizer again

Expected result

  1. The optimizer edit form page should load correctly without any error

Actual result

  1. A javascript error is thrown and visible in console "TypeError: obj is null" on line 186 of dynamic-rows-grids.js
    image
@rbayet rbayet self-assigned this Aug 2, 2019
@rbayet rbayet added the bug label Aug 2, 2019
romainruaud added a commit that referenced this issue Aug 2, 2019
Fixes #1494 JS error Optimizer empty terms selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant