Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1153 Reducing list of filterable attributes #1164

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Fixes #1153 Reducing list of filterable attributes #1164

merged 1 commit into from
Nov 9, 2018

Conversation

rbayet
Copy link
Collaborator

@rbayet rbayet commented Oct 30, 2018

to those relevant for the currently assigned products

@rbayet
Copy link
Collaborator Author

rbayet commented Oct 30, 2018 •
edited
Loading

To test fully on a multi-store environment AND in category creation mode.
Currently a resurgence of #667 in EE 2.2.5 + multi-store environment + category creation mode.
Edit : resurgence of #667 in CE 2.2.5 + single store environment on category creation mode, due to the fix in that PR

@rbayet rbayet self-assigned this Oct 30, 2018
@rbayet rbayet force-pushed the fix_1153_reduced_facet_config branch from 44f23e0 to a6fed4c Compare October 31, 2018 09:23
@rbayet
Copy link
Collaborator Author

rbayet commented Oct 31, 2018 •
edited
Loading

To test fully on a multi-store environment AND in category creation mode.
Currently a resurgence of #667 in EE 2.2.5 + multi-store environment + category creation mode.
Edit : resurgence of #667 in CE 2.2.5 + single store environment on category creation mode, due to the fix in that PR

Symptom of #667 fixed: only apply attribute set filtering if not in category creation mode.

@rbayet rbayet force-pushed the fix_1153_reduced_facet_config branch 3 times, most recently from e9eaa10 to 35df736 Compare October 31, 2018 16:20
@rbayet rbayet requested a review from romainruaud October 31, 2018 16:36
@rbayet rbayet changed the title WIP: Fixes #1153 Reducing list of filterable attributes Fixes #1153 Reducing list of filterable attributes Oct 31, 2018
@rbayet rbayet assigned romainruaud and unassigned rbayet Oct 31, 2018
@romainruaud romainruaud assigned rbayet and unassigned romainruaud Nov 5, 2018
@rbayet rbayet force-pushed the fix_1153_reduced_facet_config branch from 35df736 to 9d82615 Compare November 7, 2018 15:43
@rbayet rbayet changed the title Fixes #1153 Reducing list of filterable attributes WIP: Fixes #1153 Reducing list of filterable attributes Nov 7, 2018
@rbayet rbayet force-pushed the fix_1153_reduced_facet_config branch from 9d82615 to 1779ffe Compare November 7, 2018 17:06
@rbayet
Fixes Smile-SA#1153 Reducing list of filterable attributes
b8a99d3 
to those relevant for the currently assigned products
@rbayet rbayet force-pushed the fix_1153_reduced_facet_config branch from 1779ffe to b8a99d3 Compare November 7, 2018 17:23
@rbayet rbayet assigned romainruaud and unassigned rbayet Nov 7, 2018
@rbayet rbayet changed the title WIP: Fixes #1153 Reducing list of filterable attributes Fixes #1153 Reducing list of filterable attributes Nov 7, 2018
@romainruaud
Copy link
Collaborator

Seems great, a way less code than first version !

@romainruaud romainruaud merged commit 34f8e6d into Smile-SA:2.6.x Nov 9, 2018
@romainruaud romainruaud mentioned this pull request Nov 12, 2018
Closed
This was referenced Nov 21, 2018
Closed
Merged
@rbayet rbayet deleted the fix_1153_reduced_facet_config branch December 11, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainruaud romainruaud romainruaud left review comments

Assignees

@romainruaud romainruaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbayet @romainruaud