Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant save Category in large environment (Big Post) #1153

Closed
wouter-toppy opened this issue Oct 25, 2018 · 4 comments
Closed

Cant save Category in large environment (Big Post) #1153

wouter-toppy opened this issue Oct 25, 2018 · 4 comments
Assignees

Comments

@wouter-toppy
Copy link
Contributor

Preconditions

Magento Version : 2.2.6 and 2.3

ElasticSuite Version : 2.6.x-dev

Environment : Developer

Third party modules :

Steps to reproduce

  1. have a lot of categories with attributes.
  2. try to save them
  3. get error of invalid form key. but its actually an other error. he isnt actually submitting the the form. its posting to /admin/catalog/category/validate/ with alot of post entities [https://pastebin.com/XTjx9dAR]
  4. i believe the error is in the php setting max_input_vars but increasing those values doesnt seem to be an option in my opinion.

Expected result

  1. save the category.
  2. post the form without all the facet_config[][] entities if they havent changed. (i dont think its nessecary to make such a big post for every time the category needs to be changed)

Actual result

  1. Post Request: https://pastebin.com/XTjx9dAR

screenshot from 2018-10-25 09-28-58
screenshot from 2018-10-25 09-29-16
screenshot from 2018-10-25 09-29-43
screenshot from 2018-10-25 09-38-56

@wouter-toppy
Copy link
Contributor Author

@Swahjak you got more details to fill in the blancs?

@Swahjak
Copy link
Contributor

Swahjak commented Oct 25, 2018

The post data suggests that all attribute's that are filterable are displayed while only certain attributes affect the category. Since this is still a (relatively) small catalog I could see this "issue" increase in the future. Maybe only loading the relevant attributes could solve this problem. Maybe filtering the 'Use Default value' on post could reduce the post size as well, since this would be the most common case.

@romainruaud
Copy link
Collaborator

Hello @Swahjak

Yes, displaying only "relevant" attributes (attributes matching at least one product in the category, or attribute that have been customized for this category previously) is definitely something we were considering for this feature : better UX imho, and shall also fix this issue.

We'll have a look on this one,

Thank you for using our module and for having reported this.

Regards

rbayet added a commit to rbayet/elasticsuite that referenced this issue Oct 30, 2018
to those relevant for the currently assigned products
rbayet added a commit to rbayet/elasticsuite that referenced this issue Oct 31, 2018
to those relevant for the currently assigned products
rbayet added a commit to rbayet/elasticsuite that referenced this issue Oct 31, 2018
to those relevant for the currently assigned products
rbayet added a commit to rbayet/elasticsuite that referenced this issue Oct 31, 2018
to those relevant for the currently assigned products
rbayet added a commit to rbayet/elasticsuite that referenced this issue Oct 31, 2018
to those relevant for the currently assigned products
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 7, 2018
to those relevant for the currently assigned products
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 7, 2018
to those relevant for the currently assigned products
rbayet added a commit to rbayet/elasticsuite that referenced this issue Nov 7, 2018
to those relevant for the currently assigned products
romainruaud added a commit that referenced this issue Nov 9, 2018
Fixes #1153 Reducing list of filterable attributes
@romainruaud
Copy link
Collaborator

Fixed by PR #1164 that will be part of next minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants