Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi tools won't reset their modes after server restart #4122

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

WalshyDev
Copy link
Member

Description

Multi tools reset their mode after server restart. I found it really annoying and so did my players, so I decided to fix that.
This pull request also adds a display of current multi tool mode in its lore.
Feel free to improve my code. I tried to achieve my goal without changing too much stuff, so it shouldn't break anything.

Captura de pantalla 2023-12-28 231315

Proposed changes

  • Multi tools keep their current mode after server restart
  • Current multi tool mode is displayed in its lore (works with already existing multi tools)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Co-authored-by: womzil <[email protected]>
Co-authored-by: Fury_Phoenix <[email protected]>
Co-authored-by: Daniel Walsh <[email protected]>
@WalshyDev WalshyDev requested a review from a team as a code owner February 8, 2024 04:30
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

7 New issues
0 Security Hotspots
13.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: e24a51a3

https://preview-builds.walshy.dev/download/Slimefun/4122/e24a51a3

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@womzil
Copy link

womzil commented Apr 2, 2024

Sorry if I missed something obvious, but what has to be done in order for this change to be merged with the master branch?

@Sfiguz7 Sfiguz7 merged commit 2fb89ad into master Jun 8, 2024
17 checks passed
@Sfiguz7 Sfiguz7 deleted the womzil/master branch June 8, 2024 05:55
@Boomer-1 Boomer-1 mentioned this pull request Jun 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants