Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi tools won't reset their modes after server restart #4073

Closed
wants to merge 0 commits into from
Closed

Multi tools won't reset their modes after server restart #4073

wants to merge 0 commits into from

Conversation

womzil
Copy link

@womzil womzil commented Dec 28, 2023

Description

Multi tools reset their mode after server restart. I found it really annoying and so did my players, so I decided to fix that.
This pull request also adds a display of current multi tool mode in its lore.
Feel free to improve my code. I tried to achieve my goal without changing too much stuff, so it shouldn't break anything.

Captura de pantalla 2023-12-28 231315

Proposed changes

  • Multi tools keep their current mode after server restart
  • Current multi tool mode is displayed in its lore (works with already existing multi tools)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@womzil womzil requested a review from a team as a code owner December 28, 2023 21:56
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@womzil womzil changed the title Multitool won't reset its mode after server restart Multi tools won't reset their modes after server restart feature/** Dec 28, 2023
@womzil womzil changed the title Multi tools won't reset their modes after server restart feature/** Multi tools won't reset their modes after server restart Dec 28, 2023
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 8805e571

https://preview-builds.walshy.dev/download/Slimefun/4073/8805e571

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@womzil womzil deleted the branch Slimefun:master December 29, 2023 13:41
@womzil womzil closed this Dec 29, 2023
@womzil womzil deleted the master branch December 29, 2023 13:41
@womzil womzil restored the master branch December 29, 2023 13:45
@womzil womzil deleted the master branch December 29, 2023 13:46
@womzil womzil restored the master branch December 29, 2023 13:47
@womzil womzil reopened this Dec 29, 2023
Copy link
Member

@Phoenix-Starlight Phoenix-Starlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classes are definitely in need of a refactor, however its out-of-scope IMO. (oops I submitted two reviews)

@WalshyDev
Copy link
Member

Just to elevate Jeff's comment, this is currently blocked on - #4073 (comment)

@womzil
Copy link
Author

womzil commented Jan 24, 2024

Just to elevate Jeff's comment, this is currently blocked on - #4073 (comment)

I answered, just in case you missed it like I did 😉 - #4073 (comment)

@WalshyDev WalshyDev closed this Feb 8, 2024
@WalshyDev
Copy link
Member

master branches are such a pain to work off 😅

Opened #4122 with my small improvement on top of this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants