-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi tools won't reset their modes after server restart #4073
Conversation
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4073/8805e571
|
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
.../io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiToolMode.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
...java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/gadgets/MultiTool.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The classes are definitely in need of a refactor, however its out-of-scope IMO. (oops I submitted two reviews)
Just to elevate Jeff's comment, this is currently blocked on - #4073 (comment) |
I answered, just in case you missed it like I did 😉 - #4073 (comment) |
master branches are such a pain to work off 😅 Opened #4122 with my small improvement on top of this change |
Description
Multi tools reset their mode after server restart. I found it really annoying and so did my players, so I decided to fix that.
This pull request also adds a display of current multi tool mode in its lore.
Feel free to improve my code. I tried to achieve my goal without changing too much stuff, so it shouldn't break anything.
Proposed changes
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values