Skip to content

Updated relation parsing for actions #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichielOda merged 3 commits into from
Dec 11, 2025
Merged

Updated relation parsing for actions #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57d7d6e
Updated relation parsing for actions
PedroDebevere Oct 30, 2025
a02b701
Fixes in unit test, fixes in GetOptions for the Action & applied CR r…
MichielOda Dec 11, 2025
9523499
SonarCloud remarks
MichielOda Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Protocol/Models/Custom Classes/Protocol/Actions/Action/Type/ActionTypeOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{
using System;
using System.Collections.Generic;
using System.Linq;

public class ActionTypeOptions : OptionsBase
{
Expand Down Expand Up @@ -693,7 +694,7 @@ public JoinClass(string option) : base(option)

foreach (var part in secondParts)
{
if (UInt32.TryParse(parts[1], out uint v))
if (UInt32.TryParse(part, out uint v))
{
pids.Add(v);
}
Expand Down Expand Up @@ -1049,15 +1050,20 @@ public WhereClass(string option) : base(option)
{
string[] parts = option.Split(':');

if (parts.Length != 2)
switch (parts.Length)
{
return;
case 2:
Value = parts[1];
break;
case 3 when String.Equals(parts[1], "ID", StringComparison.OrdinalIgnoreCase) && UInt32.TryParse(parts[2], out uint id):
Pid = id;
break;
}

Value = parts[1];
}

public string Value { get; }
public string Value { get; set; }

public uint? Pid { get; set; }
}
}
}
Loading
Loading