Skip to content

Updated relation parsing for actions#120

Merged
MichielOda merged 3 commits into
mainfrom
actionsRelationManager
Dec 11, 2025
Merged

Updated relation parsing for actions#120
MichielOda merged 3 commits into
mainfrom
actionsRelationManager

Conversation

@PedroDebevere

@PedroDebevere PedroDebevere commented Oct 30, 2025

Copy link
Copy Markdown
Member

This pull request introduces significant enhancements to how action references are processed and managed in the protocol model, along with some minor code improvements and test updates. The main focus is on refactoring and extending the logic for extracting references from action types and their options, making the code more modular and maintainable.

Refactoring and Extension of Action Reference Extraction

  • Refactored IRelationEvaluator.GetRelations() in Action.cs to delegate reference extraction to new helper methods (ProcessParameterActionReferences, ProcessProtocolActionReferences, ProcessPairActionReferences, ProcessCommandActionReferences, ProcessResponseActionReferences), improving modularity and maintainability. Added support for extracting references from additional action types and their options, including complex option structures for aggregate, merge, swap, and WMI actions.

Improvements to ActionTypeOptions Parsing

  • Fixed a parsing bug in JoinClass where the wrong variable was used for PID extraction, and enhanced WhereClass to support a third part for ID parsing, adding a nullable Pid property.

Test and Project File Updates

  • Updated the test project to remove net6.0 from target frameworks and bumped MSTest to version 4.0.1 for improved compatibility.
  • Updated test assertion syntax to use Assert.Throws<T>() instead of Assert.ThrowsException<T>() for consistency with the latest MSTest version.
  • Minor formatting cleanup in the protocol test file for readability.

Comment thread Protocol/Models/Read/Protocol/Actions/Action/Action.cs Outdated
Comment thread ProtocolTests/ProtocolTests.csproj Outdated
@MichielOda MichielOda merged commit 5fc79b9 into main Dec 11, 2025
7 checks passed
@MichielOda MichielOda deleted the actionsRelationManager branch December 11, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants