Updated relation parsing for actions#120
Merged
Merged
Conversation
MichielOda
requested changes
Nov 4, 2025
MichielOda
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to how action references are processed and managed in the protocol model, along with some minor code improvements and test updates. The main focus is on refactoring and extending the logic for extracting references from action types and their options, making the code more modular and maintainable.
Refactoring and Extension of Action Reference Extraction
IRelationEvaluator.GetRelations()inAction.csto delegate reference extraction to new helper methods (ProcessParameterActionReferences,ProcessProtocolActionReferences,ProcessPairActionReferences,ProcessCommandActionReferences,ProcessResponseActionReferences), improving modularity and maintainability. Added support for extracting references from additional action types and their options, including complex option structures for aggregate, merge, swap, and WMI actions.Improvements to ActionTypeOptions Parsing
JoinClasswhere the wrong variable was used for PID extraction, and enhancedWhereClassto support a third part forIDparsing, adding a nullablePidproperty.Test and Project File Updates
net6.0from target frameworks and bumped MSTest to version 4.0.1 for improved compatibility.Assert.Throws<T>()instead ofAssert.ThrowsException<T>()for consistency with the latest MSTest version.