Remove mac specific skips #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

JimBobSquarePants merged 8 commits into SixLabors:main from stefannikolei:stefannikolei/mac

Mar 8, 2023

Contributor

stefannikolei commented Mar 5, 2023

Prerequisites

I have written a descriptive pull-request title
I have verified that there are no overlapping pull-requests open
I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
I have provided test coverage for my change (where applicable)

Description


          Remove mac specific skips

b661c07

Contributor Author

stefannikolei commented Mar 5, 2023

Strange.

Locally all tests work on my Mac..

Member

JimBobSquarePants commented Mar 6, 2023

The VMs are super low spec here so sometimes the operations we expect (GC cleanup) simply do not occur in the timescale.

It's easier just to test on a Mac locally and move on.

Member

JimBobSquarePants commented Mar 8, 2023

Looks like we can allow the Tiff decoder tests now but I would keep the MemoryAllocator ones diabled for now.


          Disable MemoryAllocator tests

56de9e7

stefannikolei commented

View reviewed changes

tests/ImageSharp.Tests/Memory/Allocators/UniformUnmanagedMemoryPoolTests.Trim.cs Outdated Show resolved Hide resolved

stefannikolei and others added 2 commits

March 8, 2023 07:17


          Update tests/ImageSharp.Tests/Memory/Allocators/UniformUnmanagedMemor…

4fb8e0d

…yPoolTests.Trim.cs


          Merge branch 'main' into stefannikolei/mac

stefannikolei commented

View reviewed changes

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Outdated Show resolved Hide resolved


          Update tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs

a613dc9

stefannikolei commented

View reviewed changes

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Outdated Show resolved Hide resolved


          Update tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs

7ebe387

stefannikolei commented

View reviewed changes

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Outdated Show resolved Hide resolved


          Update tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs

075e8a4

stefannikolei commented

View reviewed changes

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Outdated Show resolved Hide resolved

stefannikolei commented

View reviewed changes

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Outdated Show resolved Hide resolved

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Outdated Show resolved Hide resolved

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Outdated Show resolved Hide resolved


          Apply suggestions from code review

47f532b

stefannikolei marked this pull request as ready for review

March 8, 2023 07:10

JimBobSquarePants merged commit 0c8efbe into SixLabors:main

stefannikolei deleted the stefannikolei/mac branch

March 25, 2023 16:31

This was referenced Sep 29, 2025

Bump SixLabors.ImageSharp from 2.1.11 to 3.1.11 EvotecIT/OfficeIMO#1283

Closed

Bump SixLabors.ImageSharp from 2.1.11 to 3.1.11 EvotecIT/OfficeIMO#1296

Closed

dependabot bot mentioned this pull request

Bump SixLabors.ImageSharp from 2.1.11 to 3.1.11 EvotecIT/OfficeIMO#1314

Closed

dependabot bot mentioned this pull request

Bump SixLabors.ImageSharp from 2.1.11 to 3.1.12 EvotecIT/OfficeIMO#1339

Closed

This was referenced Nov 17, 2025

Bump SixLabors.ImageSharp from 2.1.11 to 3.1.12 EvotecIT/OfficeIMO#1362

Closed

Bump SixLabors.ImageSharp from 2.1.11 to 3.1.12 yildirim-mehmet/onlineOfiice#8

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet