Merge pull request #2384 from stefannikolei/stefannikolei/mac

Remove mac specific skips

Author: JimBobSquarePants

tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs

@@ -202,13 +202,6 @@ public void TiffDecoder_CanDecode_12Bit_WithUnassociatedAlpha<TPixel>(TestImageP
     public void TiffDecoder_CanDecode_12Bit_WithAssociatedAlpha<TPixel>(TestImageProvider<TPixel> provider)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        if (TestEnvironment.IsMacOS)
-        {
-            // Only debug save on OSX: For some reason the reference image has a difference of 50%. The imagesharp output file looks ok though.
-            using Image<TPixel> image = provider.GetImage(TiffDecoder.Instance);
-            image.DebugSave(provider);
-            return;
-        }
 
         TestTiffDecoder(provider, useExactComparer: false, compareTolerance: 0.264F);
     }
@@ -258,13 +251,6 @@ public void TiffDecoder_CanDecode_20Bit_WithAssociatedAlpha<TPixel>(TestImagePro
 
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        if (TestEnvironment.IsMacOS)
-        {
-            // Only debug save on OSX: For some reason the reference image has a difference of 50%. The imagesharp output file looks ok though.
-            using Image<TPixel> image = provider.GetImage(TiffDecoder.Instance);
-            image.DebugSave(provider);
-            return;
-        }
 
         TestTiffDecoder(provider, useExactComparer: false, compareTolerance: 0.376F);
     }
@@ -284,13 +270,6 @@ public void TiffDecoder_CanDecode_24Bit_WithUnassociatedAlpha<TPixel>(TestImageP
     public void TiffDecoder_CanDecode_24Bit_WithAssociatedAlpha<TPixel>(TestImageProvider<TPixel> provider)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        if (TestEnvironment.IsMacOS)
-        {
-            // Only debug save on OSX: For some reason the reference image has a difference of 50%. The imagesharp output file looks ok though.
-            using Image<TPixel> image = provider.GetImage(TiffDecoder.Instance);
-            image.DebugSave(provider);
-            return;
-        }
 
         TestTiffDecoder(provider, useExactComparer: false, compareTolerance: 0.405F);
     }
@@ -385,13 +364,6 @@ public void TiffDecoder_CanDecode_32Bit_WithUnassociatedAlpha<TPixel>(TestImageP
     public void TiffDecoder_CanDecode_32Bit_WithAssociatedAlpha<TPixel>(TestImageProvider<TPixel> provider)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        if (TestEnvironment.IsMacOS)
-        {
-            // Only debug save on OSX: For some reason the reference image has a difference of 50%. The imagesharp output file looks ok though.
-            using Image<TPixel> image = provider.GetImage(TiffDecoder.Instance);
-            image.DebugSave(provider);
-            return;
-        }
 
         // Note: Using tolerant comparer here, because there is a small difference to the reference decoder probably due to floating point rounding issues.
         TestTiffDecoder(provider, useExactComparer: false, compareTolerance: 0.004F);
@@ -425,13 +397,6 @@ public void TiffDecoder_CanDecode_40Bit_WithUnassociatedAlpha<TPixel>(TestImageP
     public void TiffDecoder_CanDecode_40Bit_WithAssociatedAlpha<TPixel>(TestImageProvider<TPixel> provider)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        if (TestEnvironment.IsMacOS)
-        {
-            // Only debug save on OSX: For some reason the reference image has a difference of 50%. The imagesharp output file looks ok though.
-            using Image<TPixel> image = provider.GetImage(TiffDecoder.Instance);
-            image.DebugSave(provider);
-            return;
-        }
 
         TestTiffDecoder(provider, useExactComparer: false, compareTolerance: 0.247F);
     }
@@ -463,13 +428,6 @@ public void TiffDecoder_CanDecode_48Bit_WithUnassociatedAlpha<TPixel>(TestImageP
     public void TiffDecoder_CanDecode_48Bit_WithAssociatedAlpha<TPixel>(TestImageProvider<TPixel> provider)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        if (TestEnvironment.IsMacOS)
-        {
-            // Only debug save on OSX: For some reason the reference image has a difference of 50%. The imagesharp output file looks ok though.
-            using Image<TPixel> image = provider.GetImage(TiffDecoder.Instance);
-            image.DebugSave(provider);
-            return;
-        }
 
         TestTiffDecoder(provider, useExactComparer: false, compareTolerance: 0.118F);
     }
@@ -492,13 +450,6 @@ public void TiffDecoder_CanDecode_56Bit_WithUnassociatedAlpha<TPixel>(TestImageP
     public void TiffDecoder_CanDecode_56Bit_WithAssociatedAlpha<TPixel>(TestImageProvider<TPixel> provider)
         where TPixel : unmanaged, IPixel<TPixel>
     {
-        if (TestEnvironment.IsMacOS)
-        {
-            // Only debug save on OSX: For some reason the reference image has a difference of 50%. The imagesharp output file looks ok though.
-            using Image<TPixel> image = provider.GetImage(TiffDecoder.Instance);
-            image.DebugSave(provider);
-            return;
-        }
 
         TestTiffDecoder(provider, useExactComparer: false, compareTolerance: 0.075F);
     }

tests/ImageSharp.Tests/Processing/Processors/Transforms/ResizeTests.cs

@@ -31,7 +31,7 @@ public class ResizeTests
         };
 
     private static readonly ImageComparer ValidatorComparer =
-        ImageComparer.TolerantPercentage(TestEnvironment.IsMacOS && TestEnvironment.RunsOnCI ? 0.26F : 0.07F);
+        ImageComparer.TolerantPercentage(0.07F);
 
     [Fact]
     public void Resize_PixelAgnostic()