[nextjs] Fix double placeholder in Experience Editor in production mode #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
approved these changes
Jul 7, 2023
sc-addypathania
force-pushed
the
bug/587850-double-placeholder
branch
from
0d52a1e
to
f2fc3d9
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Remove workaround from bug 540957 (#1161) that addressed placeholder hydration errors.
This will bring back hydration console errors when using jss connected mode in rendering host, but will get rid of issues when using rendering host in production mode instead (which is a better tradeoff).
Testing Details
Types of changes