Getting rid of hydration errors for nextjs pages in ExpEditor #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
approved these changes
Sep 20, 2022
|
@ambrauer it shouldn't be. Placeholders appear to behave slightly different on Pages and hydration error does not occur when I tested (at least on XM Cloud deployment). |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a workaround for Experience Editor to make it work better with nextjs apps and avoid hydration errors that started occurring after next and react version upgrades.
Description / Motivation
React will add specific markup for empty placeholders in Experience Editor on first page load. This way it won't be "confused" by this markup when Experience Editor client side scripts add it.
Types of changes