Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports, type hints and fixtures for goal oriented tests #3415

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Apr 27, 2023

Background

Addendum on #3387

Changes

  • Fix tests.vcr imports
  • Change create_browse_agent to browse_agent fixture, create_write_agent idem
  • Clean up test_write_file and test_browse_website

Test Plan

See CI

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Apr 27, 2023 5:08pm

@Pwuts Pwuts added the testing label Apr 27, 2023
@Pwuts Pwuts self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +3.46 🎉

Comparison is base (7cd76b8) 51.42% compared to head (0e35497) 54.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3415      +/-   ##
==========================================
+ Coverage   51.42%   54.89%   +3.46%     
==========================================
  Files          65       65              
  Lines        3016     3015       -1     
  Branches      507      507              
==========================================
+ Hits         1551     1655     +104     
+ Misses       1339     1224     -115     
- Partials      126      136      +10     
Impacted Files Coverage Δ
autogpt/main.py 0.00% <0.00%> (ø)
autogpt/prompts/prompt.py 56.60% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@collijk collijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@Pwuts Pwuts merged commit 3d89ed1 into Significant-Gravitas:master Apr 27, 2023
@Pwuts Pwuts deleted the tests/goal-oriented-fix-imports-and-fixtures branch April 27, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants