Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse Site Regression test #3387

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Browse Site Regression test #3387

merged 2 commits into from
Apr 27, 2023

Conversation

waynehamadi
Copy link
Contributor

Background

Browse website is a command that browses a url and answers a question using the content as an input. Very important for AutoGPT, it can't break

Changes

added regression test.

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@vercel
Copy link

vercel bot commented Apr 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 4:21pm

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from c80db0d to 186cb93 Compare April 27, 2023 06:06
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from 186cb93 to 004c149 Compare April 27, 2023 06:11
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from 004c149 to f2543be Compare April 27, 2023 06:13
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from f2543be to 9150ed8 Compare April 27, 2023 06:14
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from 9150ed8 to 5d2360d Compare April 27, 2023 06:21
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi changed the title Feature/scrape text regression test Browse Site Regression test Apr 27, 2023
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: +3.42 🎉

Comparison is base (7cd76b8) 51.42% compared to head (05d6d6c) 54.84%.

❗ Current head 05d6d6c differs from pull request most recent head 171d783. Consider uploading reports for the commit 171d783 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3387      +/-   ##
==========================================
+ Coverage   51.42%   54.84%   +3.42%     
==========================================
  Files          65       65              
  Lines        3016     3012       -4     
  Branches      507      508       +1     
==========================================
+ Hits         1551     1652     +101     
+ Misses       1339     1223     -116     
- Partials      126      137      +11
Impacted Files Coverage Δ
autogpt/main.py 0.00% <0.00%> (ø)
autogpt/prompts/prompt.py 56.60% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pwuts Pwuts added this to the v0.3.0 release milestone Apr 27, 2023
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from 5693e5c to 6fed4c7 Compare April 27, 2023 14:13
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from 6fed4c7 to dba0079 Compare April 27, 2023 14:15
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@waynehamadi waynehamadi force-pushed the feature/scrape-text-regression-test branch from dba0079 to 05d6d6c Compare April 27, 2023 14:16
@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

@github-actions
Copy link
Contributor

This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size

collijk
collijk approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@collijk collijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests work on my end. Looks good!

@vercel vercel bot temporarily deployed to Preview April 27, 2023 16:21 Inactive
@collijk collijk merged commit adbb47f into Significant-Gravitas:master Apr 27, 2023
@Pwuts Pwuts mentioned this pull request Apr 27, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collijk collijk collijk approved these changes

Assignees
No one assigned
Labels
size/xl testing
Projects
AutoGPT development kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waynehamadi @collijk @ntindle @Pwuts