Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command_name converted to lowercase #2326

Conversation

lengweiping1983
Copy link
Contributor

@lengweiping1983 lengweiping1983 commented Apr 18, 2023

Background

command_name converted to lowercase to increase the robustness of the code

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thoroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

except Exception as e:
logger.error("Error: \n", str(e))

# Print command
logger.typewriter_log(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes? Should probably be a separate PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command name contains two types:
one is to be executed by the AI,
and the other is to compare the input by the user with the preset one and convert it to lowercase to increase the robustness of the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these changes? Should probably be a separate PR

change to only command_name converted to lowercase.

@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Apr 20, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts Automatically applied to PRs with merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants