-
Notifications
You must be signed in to change notification settings - Fork 45.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The key of the agent manager is converted to str, simplifying the code #2311
The key of the agent manager is converted to str, simplifying the code #2311
Conversation
@lengweiping1983 Thank you for your contributions to the project! If you ever feel that your pull requests need attention, please feel free to reach out to our merging team directly on our Discord channel. We're constantly working to improve the merging process, such as adding features like the conflict notification bot. We apologize for any inconvenience caused by the early bug in the bot, which led to multiple notifications for some users. I also noticed that you've closed a few pull requests without leaving comments. To ensure better communication and understanding, it would be helpful if you could kindly leave a brief note explaining your decision when closing a request. In cases where pull requests are closed abruptly, we assign @BillSchumacher to review them and determine if they can be salvaged. By leaving a comment, you can help us avoid any confusion and allow @BillSchumacher to focus on other tasks. If you're planning to redo a pull request from scratch, letting us know would be greatly appreciated. Thanks again for your efforts, and we look forward to your continued contributions! |
The reason for closing is that each pull request does not start from the master branch again, which may cause trouble for your review, so the pull request is resubmitted after decomposition. I'll pay attention next time. |
I saw the code in the script of cli.py (called main.py yesterday), as follows:
Where is the value of the ai_name variable obtained, it cannot be seen here,so I want optimize the code, Currently only one of them is optimized, please review. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
1 similar comment
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
3bf9ffa
to
88cb487
Compare
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
88cb487
to
07469b0
Compare
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)autogpt/agent/agent_manager.py
autogpt/app.py
|
This is a mass message from the AutoGPT core team. For more details (and for infor on joining our Discord), please refer to: |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Thanks, this caused us quite a bit of issues earlier. The AgentManager has since been deprecated while we work on a new structure for dispatching (fully-featured) sub-agents. Stay tuned! :) |
Background
The following is about the key type of the agent manager.
There are many ways to write the key type in the code:
and conversion is required in use.
The key type of the agent manager is change to str, simplifying the code, only use str and not required conversion.
Changes
The key type of the agent manager is change to str.
Documentation
Test Plan
PR Quality Checklist