Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the correct algorithm to request item information #936

Merged
merged 3 commits into from
Jul 23, 2021

Commits on Jul 22, 2021

  1. fix: use callbacks to fetch item information from the server

    It turns out that you do need to use callbacks to fetch all item
    information from the server.  Modify the update code to listen for
    ITEM_DATA_LOAD_RESULT events to execute a callback to properly
    update an equipped item.
    
    Change the way that `Ovale_EquipmentChanged` is fired by always
    including the slot name that has been changed.  The event now fires
    whenever ITEM_DATA_LOAD_RESULT returns success and the slot that
    had a pending data load has been changed.
    
    This avoids needing the 3-second delay kludge to wait for server
    data.
    johnnylam88 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    f1a9df6 View commit details
    Browse the repository at this point in the history
  2. fix: consistently use SlotName instead of InventorySlotName in API

    Make all Ovale modules consistently use `ammoslot`, etc., instead
    of `AMMOSLOT`, etc., to refer to the names of the equipment slots.
    Make the conversion between the `SlotName` and `InventorySlotName`
    types internal to the `Equipment` module.
    johnnylam88 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    e91ff8c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Configuration menu
    Copy the full SHA
    133c501 View commit details
    Browse the repository at this point in the history