fix: use the correct algorithm to request item information #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that you do need to use callbacks to fetch all item information from the server. Modify the update code to listen for ITEM_DATA_LOAD_RESULT events to execute a callback to properly update an equipped item. Change the way that `Ovale_EquipmentChanged` is fired by always including the slot name that has been changed. The event now fires whenever ITEM_DATA_LOAD_RESULT returns success and the slot that had a pending data load has been changed. This avoids needing the 3-second delay kludge to wait for server data.
Make all Ovale modules consistently use `ammoslot`, etc., instead of `AMMOSLOT`, etc., to refer to the names of the equipment slots. Make the conversion between the `SlotName` and `InventorySlotName` types internal to the `Equipment` module.
|
Merging the latest master commits to bump the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some occasional bugs in the values returned by the
Equipmentmodule, caused by item information not being available when the module
requests it.
This pullup requires an update to the
wow-mockdependency:wowts/wow-mock#15