Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add macos amd64 desktop #786

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

alexfreska
Copy link
Member

  • The desktop downloads now include AMD64 for macOS.

Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 4:51pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 4:51pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 4:51pm
hostd ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 4:51pm
renterd ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 4:51pm

Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: 2c10bb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
website Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexfreska and the rest of your teammates on Graphite Graphite

@n8maninger
Copy link
Member

n8maninger commented Oct 21, 2024

Looks like a problem with the GitHub release. This is downloading the .zip instead of the .dmg. However, it doesn't look like there is a platform specififc .dmg available on GitHub. It's likely the amd64/arm64 builds are overwriting each other. @alexfreska can you change the name of the artifact in electron forge? You used to be able to with electron builder.

@alexfreska alexfreska force-pushed the feat_website_add_macos_amd64_desktop branch 2 times, most recently from 13773a9 to 898937c Compare October 22, 2024 16:37
Copy link
Member Author

@n8maninger I've added dmgs for both architectures over on desktop: SiaFoundation/desktop#96 and updated this PR to match those changes.

@alexfreska alexfreska merged commit c72f826 into main Oct 22, 2024
37 checks passed
@alexfreska alexfreska deleted the feat_website_add_macos_amd64_desktop branch October 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants