test: extract e2e fixtures into library #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexfreska
commented
Oct 11, 2024
•
alexfreska
commented
- Added new library for shared e2e testing fixtures and methods.
- There were many repeated helpers across all our e2e testing apps. Initially I duplicated them to avoid a premature abstraction, but they have now settled and are the same across all apps.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 024db64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alexfreska and the rest of your teammates on |
alexfreska
force-pushed
the
test_extract_e2e_fixtures_into_library
branch
from
fea02d4 to
67e12fb
Compare
alexfreska
force-pushed
the
test_extract_e2e_fixtures_into_library
branch
from
67e12fb to
3f343ac
Compare
telestrial
approved these changes
Oct 11, 2024
alexfreska
force-pushed
the
test_extract_e2e_fixtures_into_library
branch
from
3f343ac to
e2d04ce
Compare
alexfreska
force-pushed
the
test_extract_e2e_fixtures_into_library
branch
from
e2d04ce to
024db64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.