fix: explored-types: add 'type' to core types import, silencing webpack empty export warning

[telestrial]

In creating this PR: #698

I discovered a webpack-related warning for our import of core types in the explored-types. By doing:

import { Address, ... } from '@siafoundation/types'

this led to an avalanche of warnings like so:

export 'Address' (reexported as 'Address') was not found in '@siafoundation/types' (module has no exports)

By adding the 'type' at the top of types.ts:

import type { Address, ... } from '@siafoundation/types'

this warning no longer sounds. I believe this has to do with some bare metal typescript -> javascript transpilation + importing rules at the webpack level. There was no obvious bug/misbehavior as a result of the former implementation. The library worked, from what I tested, and types were valid/enforced, even with this warning.

In terms of where to put the type keyword, I believe from testing one could also do it here:

export type {
  Address,
  Block,
  BlockID,
  ...
}

but I like it at the import better. Everything 'up the tree' or neighboring (but also importing from) either explicitly defines a type to export, uses these core imported types, and/or uses primitives. In some sense, putting it at the import strikes at "a single source of truth"--our core types. This import is the parent of everything in this library beyond primitives, so it seems right at this spot.

For more information about the warning/solution, see this comment and the rest of the thread.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
explorer	⬜️ Ignored (Inspect)	Visit Preview		Aug 26, 2024 8:07pm
explorer-zen	⬜️ Ignored (Inspect)	Visit Preview		Aug 26, 2024 8:07pm
hostd	⬜️ Ignored (Inspect)	Visit Preview		Aug 26, 2024 8:07pm
renterd	⬜️ Ignored (Inspect)	Visit Preview		Aug 26, 2024 8:07pm
website	⬜️ Ignored (Inspect)	Visit Preview		Aug 26, 2024 8:07pm

[changeset-bot]

🦋 Changeset detected

Latest commit: ff362cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@siafoundation/explored-types	Minor
@siafoundation/explored-js	Patch
@siafoundation/explored-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR