Generate CachedSize function for Placement vindex#102
Merged
brendar merged 1 commit intov15.0.3-shopify-3from Jun 15, 2023
Merged
Generate CachedSize function for Placement vindex#102brendar merged 1 commit intov15.0.3-shopify-3from
brendar merged 1 commit intov15.0.3-shopify-3from
Conversation
Generated via `make sizegen` Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com>
austenLacy
approved these changes
Jun 14, 2023
Author
|
Looks like the remaining test failure for "Run Upgrade Downgrade Test - Reparent Old VTTablet" is a known failure introduced when changes from #90 were applied to this branch. We can fix them by replacing e8f37e2 with the changes from Will's upstream PR vitessio@d95cffd. I'll do that in a separate issue. |
shanth96
pushed a commit
that referenced
this pull request
Mar 21, 2024
…t-vindex Generate CachedSize function for Placement vindex (cherry picked from commit 986ffc6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated via
make sizegenFixes this Static Code Checks Etc workflow failure:
Impact
Based on vitessio#7387 and vitessio#7439, it looks like the
CachedSizefunction is used to calculate how much memory a struct requires, and that is used to determine total cache size in memory, trigger eviction, and determine whether a struct should be cached at all. This change makes that calculation slightly more accurate, so I don't expect it to have a noticeable impact.Why didn't we catch this sooner?
The Static Code Checks Etc workflow is skipped under certain conditions. Opening a PR will cause the workflow to run. I suspect we simply didn't notice the workflow failure in the original Placement vindex PR: #77