Patch throttler to return 200 to fix bug when throttler isn't open#100
Merged
austenLacy merged 1 commit intov15.0.3-shopify-3from Jun 20, 2023
Merged
Conversation
|
I believe this patch will be needed until v17.0, which includes fixes for this issue: vitessio#13175 as well as changes in vitessio@261b06a and vitessio@48e71a5 as described in this PR vitessio#13130 (comment) |
Author
|
@brendar do you think we should include this patch as well since we do a lot of vstreams on replicas? vitessio@48e71a5#diff-5769de2b899c17fddf7e0b81e65bc3cabd23ee4577cd18dd00e461450deb2b11L150 |
|
That's a good catch, but it looks like that function was introduced for topo-based throttling in this commit and I can't find any similar logic on v15. Side note: given the number of fixes applied to topo-based throttling in v17, I suspect we should wait until v17 to use it. |
|
Opened a PR to address the Static Code Checks Etc workflow failure: #102 |
brendar
approved these changes
Jun 14, 2023
shanth96
pushed a commit
that referenced
this pull request
Mar 21, 2024
(cherry picked from commit 08c7694)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Patch vstreamer throttle check bug.
re: