Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed podspec to play nicer with other native libraries #504

Merged
merged 1 commit into from
May 23, 2022

Conversation

chrfalch
Copy link
Contributor

@chrfalch chrfalch commented May 23, 2022

There was an issue with including both RN Skia / Renanimated where running pod install failed with the following error message:

Can't merge user_target_xcconfig for pod targets:....

This was caused by both RN Skia and Reanimated trying to set the active C++ version to two different versions.

Running npx pod install ios worked - but the error is visible when installing with local cocoapods: pod install ios in the root of a new project.

Moving setting the xcconfig variables to the pod_target_xcconfig solved the issue.

Tested in iOS on a new project using local cocoapods. Also verified that the included settings from the podspec file are set correctly in Xcode.

Fixed #405

There was an issue with including both RN Skia / Renanimated where running pod install failed with the following error message:

`Can't merge user_target_xcconfig for pod targets:....`

This was caused by both RN Skia and Reanimated trying to set the active C++ version to two different versions.

Running `npx pod install ios` worked - but the error is visible when installing with local cocoapods: `pod install ios` in the root of  a new project.

Moving setting the xcconfig variables to the `pod_target_xcconfig` solved the issue.

Tested in iOS on a new project using local cocoapods. Also verified that the included settings from the podspec file are set correctly in XCode.
@chrfalch chrfalch requested a review from wcandillon May 23, 2022 10:45
Copy link
Contributor

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@wcandillon wcandillon merged commit 35ecbfe into main May 23, 2022
@wcandillon wcandillon deleted the fix/405-fix-xconfig-in-podspec branch September 21, 2022 07:00
@rayraydejesus
Copy link

There was an issue with including both RN Skia / Renanimated where running pod install failed with the following error message:

Can't merge user_target_xcconfig for pod targets:....

This was caused by both RN Skia and Reanimated trying to set the active C++ version to two different versions.

Running npx pod install ios worked - but the error is visible when installing with local cocoapods: pod install ios in the root of a new project.

Moving setting the xcconfig variables to the pod_target_xcconfig solved the issue.

Tested in iOS on a new project using local cocoapods. Also verified that the included settings from the podspec file are set correctly in Xcode.

Fixed #405

Where do I fix this in x code? Or I may not be understanding properly... My warning is being flagged by RN Reanimated and hermes-engine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clash with Reanimated - CLANG_CXX_LANGUAGE_STANDARD has different values
3 participants