-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clash with Reanimated - CLANG_CXX_LANGUAGE_STANDARD has different values #405
Comments
same issue |
@schiller-manuel Should we remove our CLANG-version to avoid this, or is there another solution to fix this? |
reanimated explicitly specifies so this collides with our So for now, removing |
Will this affect in any way compilation of react-native-skia, or should we just do this to make sure we don't collide with Reanimated? |
We might get some warnings when trying to use C++17 features. Reanimated could also raise its c++ version, a PR there might be worth a try. |
I tried to reproduce this issue but it builds fine for me: npx react-native init SkiaReanimated
cd SkiaReanimated
yarn add react-native-reanimated
yarn add @shopify/react-native-skia
npx pod-install
yarn ios
Can you help me reproduce this issue please? Which combination of the dependencies cause it for you? |
How did you guys solve this? |
I could not reproduce this issue. If you have hints on how to reproduce, please let me know. |
I'm experiencing this with the below dependencies. We will be updating packages later this week so will update if that changes anything. dependencies: { |
I'm experiencing this with the below dependencies. dependencies: { |
yarn add [email protected] Then patch it |
I am using but still having multiple warnings:
Is this really solved? |
Hi @kockok, this doesn't seem related to react-native-skia, which should have been in the list of targets (related to ["RNReanimated", "hermes-engine"]). We changed this to use a per-pod based configuration a while ago. |
Just set the CXX n the podspec.
Change to:
|
It seems RNReanimated uses |
This is not true. in 2.10.0 it is still c++14 |
react-native-reanimated version 3 uses just run |
That is a rc.2 and not released properly yet. |
It worked. Thanks @dankocher |
When installing both RN Reanimated and RN Skia, upon pod install I come across the following error message:
"Can't merge user_target_xcconfig for pod targets: ["RNReanimated", "hermes-engine", "react-native-skia", "Api", "Jsi", "RNSkia", "SkiaHeaders", "Utils"]. Singular build setting CLANG_CXX_LANGUAGE_STANDARD has different values"
This has happened across all versions of React from 0.65 to 0.68, as well as earlier versions of RN Reanimated.
Thanks in advance.
Kind regards,
Mani
The text was updated successfully, but these errors were encountered: