[polaris.shopify.com] Fix component lifecycle url in alpha banners #8573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurkim
force-pushed
the
lo/fix-alpha-banners
branch
from
deb00ac to
b69bf1d
Compare
kyledurand
approved these changes
Mar 7, 2023
Merged
kyledurand
pushed a commit
that referenced
this pull request
Mar 7, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#8546](#8546) [`8872c0861`](8872c08) Thanks [@MindRave](https://github.com/MindRave)! - Added "magic" color to the Icon component's color prop type. - [#8545](#8545) [`7c174e47a`](7c174e4) Thanks [@alex-page](https://github.com/alex-page)! - Updated DropZone with a signifigant restructure to remove Class child component - [#8525](#8525) [`8a4de8168`](8a4de81) Thanks [@rcaplanshopify](https://github.com/rcaplanshopify)! - [IndexTable] Adds support for header config object alignment property and treatment of right-aligned, sortable column headings - [#8569](#8569) [`646fba23f`](646fba2) Thanks [@kyledurand](https://github.com/kyledurand)! - Allowed aria attributes on Bleed, Inline, and Columns ### Patch Changes - [#8581](#8581) [`336d14545`](336d145) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where bulk actions wouldn't render when only promoted actions exist ## @shopify/[email protected] ## [email protected] ### Patch Changes - [#8570](#8570) [`45ca38d41`](45ca38d) Thanks [@laurkim](https://github.com/laurkim)! - Added `Legacy` status to component lifecycle page and banner/badge to `LegacyStack` and `LegacyCard` - [#8573](#8573) [`0389fd8b8`](0389fd8) Thanks [@laurkim](https://github.com/laurkim)! - Fixed links to component lifecycle page in alpha component banners - Updated dependencies \[[`336d14545`](336d145), [`8872c0861`](8872c08), [`7c174e47a`](7c174e4), [`8a4de8168`](8a4de81), [`646fba23f`](646fba2)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rdott
added a commit
that referenced
this pull request
Mar 7, 2023
…8573) Noticed a broken URL in the alpha banner of Columns for the component lifecycle page. Also updated the copy for all the URLs to match what is in LegacyCard and LegacyStack based off this [feedback](#8570 (comment)) for consistency. <img width="1195" alt="columns-1" src="https://user-images.githubusercontent.com/26749317/223420647-00579282-fa42-40e3-858b-4d5e1bb55681.png"> Fixes typo in Columns alpha banner. Updated copy in alpha component banner from `Component lifecycle` to `component lifecycles`. <!-- ℹ️ Delete the following for small / trivial changes --> 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…hopify#8573) ### WHY are these changes introduced? Noticed a broken URL in the alpha banner of Columns for the component lifecycle page. Also updated the copy for all the URLs to match what is in LegacyCard and LegacyStack based off this [feedback](Shopify#8570 (comment)) for consistency. <img width="1195" alt="columns-1" src="https://user-images.githubusercontent.com/26749317/223420647-00579282-fa42-40e3-858b-4d5e1bb55681.png"> ### WHAT is this pull request doing? Fixes typo in Columns alpha banner. Updated copy in alpha component banner from `Component lifecycle` to `component lifecycles`. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [Shopify#8546](Shopify#8546) [`8872c0861`](Shopify@8872c08) Thanks [@MindRave](https://github.com/MindRave)! - Added "magic" color to the Icon component's color prop type. - [Shopify#8545](Shopify#8545) [`7c174e47a`](Shopify@7c174e4) Thanks [@alex-page](https://github.com/alex-page)! - Updated DropZone with a signifigant restructure to remove Class child component - [Shopify#8525](Shopify#8525) [`8a4de8168`](Shopify@8a4de81) Thanks [@rcaplanshopify](https://github.com/rcaplanshopify)! - [IndexTable] Adds support for header config object alignment property and treatment of right-aligned, sortable column headings - [Shopify#8569](Shopify#8569) [`646fba23f`](Shopify@646fba2) Thanks [@kyledurand](https://github.com/kyledurand)! - Allowed aria attributes on Bleed, Inline, and Columns ### Patch Changes - [Shopify#8581](Shopify#8581) [`336d14545`](Shopify@336d145) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed a bug where bulk actions wouldn't render when only promoted actions exist ## @shopify/[email protected] ## [email protected] ### Patch Changes - [Shopify#8570](Shopify#8570) [`45ca38d41`](Shopify@45ca38d) Thanks [@laurkim](https://github.com/laurkim)! - Added `Legacy` status to component lifecycle page and banner/badge to `LegacyStack` and `LegacyCard` - [Shopify#8573](Shopify#8573) [`0389fd8b8`](Shopify@0389fd8) Thanks [@laurkim](https://github.com/laurkim)! - Fixed links to component lifecycle page in alpha component banners - Updated dependencies \[[`336d14545`](Shopify@336d145), [`8872c0861`](Shopify@8872c08), [`7c174e47a`](Shopify@7c174e4), [`8a4de8168`](Shopify@8a4de81), [`646fba23f`](Shopify@646fba2)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Noticed a broken URL in the alpha banner of Columns for the component lifecycle page.
Also updated the copy for all the URLs to match what is in LegacyCard and LegacyStack based off this feedback for consistency.
WHAT is this pull request doing?
Fixes typo in Columns alpha banner.
Updated copy in alpha component banner from
Component lifecycletocomponent lifecycles.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes