Upgrade body-parser in css-module

[arlyxiao]

Description

Fixed the issue below

node version: v16.13.2

Reproduce steps:

1. Clone the project
2. Go to the folder: examples/css-modules
3. yarn install && yarn dev

Additional context

---

Before submitting the PR, please make sure you do the following:

• Read the Contributing Guidelines
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
• Update docs in this repository according to your change
• Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

[caution-tape-bot]

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file,
you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

[arlyxiao]

There are two solutions to fix this:

1. Upgrade body-parser (1.20.0) can fix it.
2. Remove it.

The example doesn't use the package. It can be removed.

compression is useless. I think it can be removed too.

@jplhomer

[jplhomer]

I'm confused. The inclusion of these packages as deps should not cause a dev server error. They are not used in the Hydrogen dev server. 🤔 Can you walk me through the reasoning here?

[arlyxiao]

The error is from the file: examples/css-modules/node_modules/@shopify/hydrogen/node_modules/body-parser/node_modules/http-errors/index.js:261:45)

The statuses object doesn't have message property

Take a look at the commit (6 months ago) in the http-errors.

jshttp/http-errors@8c38486

This can explain that why it throws the error. statuses object which is from another dependency package is not the latest with http-errors package.

When upgrade body-parser into the latest(1.20.0). Then all of the dependencies are latest. So the issue disappear. @jplhomer

[blittle]

Thank you for finding this!

Instead of removing body-parser, I would rather that we upgrade it to the latest. You are right, the template doesn't currently need it, but it's meant as a starter. The moment someone starts to take advantage of more advanced features, like the <Form> component, it will be necessary.

[arlyxiao]

@blittle

I did one fresh clone and tried again. That issue didn't happen again.
However I still upgraded that and rebase with the latest.

@jplhomer removed the locked file before.

This PR might be closed.

[blittle]

It looks like it's no longer a problem. It would still be great to update those dependencies. @jplhomer any reason the yarn lock file was removed?

[jplhomer]

We don't want yarn.lock files in examples, since it pins the version of Hydrogen to older things and makes it hard to npx them to the latest version. It is gitignored, so I'm not sure how it made it in initially: https://github.com/Shopify/hydrogen/blob/main/.gitignore#L133

[blittle]

@arlyxiao as long as body-parser is updated here, might as well also update it for the framework and in the default template.

[arlyxiao]

I'm happy with doing that.

Updated. It's not necessary to add changeset? @blittle

[blittle]

Thank you @arlyxiao!

[blittle]

I'm happy with doing that.

Updated. It's not necessary to add changeset? @blittle

Add the changeset and you'll be in the release notes :)