Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify homebrew node when running homebrew-installed CLI #753

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Specify homebrew node when running homebrew-installed CLI #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packaging/src/shopify-cli.rb.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class ShopifyCli{% if formulaVersion %}AT{{formulaVersion}}{% endif %} < Formula
executable_path = "#{libexec}/bin/shopify"
FileUtils.move(executable_path, "#{executable_path}-original")
executable_content = <<~SCRIPT
#!/usr/bin/env node
#!/usr/bin/env #{libexec}/bin/node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @amcaplan should this be #!#{libexec}/bin/node? if we hard code the absolute path we shouldn't be needing env anymore


process.env.SHOPIFY_RUBY_BINDIR = "#{Formula["ruby"].opt_bin}"
process.env.SHOPIFY_HOMEBREW_FORMULA = "shopify-cli{% if formulaVersion %}@{{formulaVersion}}{% endif %}"
Expand Down