Specify homebrew node when running homebrew-installed CLI #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzaloriestra
approved these changes
Nov 9, 2022
Arkham
reviewed
Nov 10, 2022
| @@ -39,7 +39,7 @@ class ShopifyCli{% if formulaVersion %}AT{{formulaVersion}}{% endif %} < Formula | |||
| executable_path = "#{libexec}/bin/shopify" | |||
| FileUtils.move(executable_path, "#{executable_path}-original") | |||
| executable_content = <<~SCRIPT | |||
| #!/usr/bin/env node | |||
| #!/usr/bin/env #{libexec}/bin/node | |||
There was a problem hiding this comment.
hey @amcaplan should this be #!#{libexec}/bin/node? if we hard code the absolute path we shouldn't be needing env anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #697
Node < 14.17 doesn't work on mac hardware.
WHAT is this pull request doing?
This makes Homebrew-installed CLI use the Homebrew-installed Node formula, which should be a very up-to-date version.
It also has the benefit of decoupling CLI Node from the Node version used by the developer at the time (project settings, system settings, etc.) so
nvm use ____can't break the CLI.How to test your changes?
vim $(brew --prefix)/bin/shopifyand change the first line to#!/usr/bin/env /opt/homebrew/bin/nodeNow changing node versions in
nvmcan't break the CLI!Post-release steps
This will only take effect once we push the changes to the
homebrew-shopifyrepo.Measuring impact
How do we know this change was effective? Please choose one:
Checklist
devordeployhave been reflected in the internal flowchart.