Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid IsGUIDInGroup call #26

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

Exoridus
Copy link

I have noticed some Lua errors getting thrown by Killtrack since the latest wrath patch.
It seems that this is caused due IsGUIDInGroup() not accepting invalid GUIDs anymore instead of failing gracefully.

Stack trace from Bugsack:

162x KillTrack/KillTrack.lua:337: Usage: IsGUIDInGroup(guid[, groupType])
[string "=[C]"]: in function `IsGUIDInGroup'
[string "@KillTrack/KillTrack.lua"]:337: in function `IsInGroup'
[string "@KillTrack/KillTrack.lua"]:228: in function `?'
[string "@KillTrack/KillTrack.lua"]:116: in function `OnEvent'
[string "@KillTrack/KillTrack.lua"]:737: in function <KillTrack/KillTrack.lua:737>

Locals:
(*temporary) = "<No One>"

@Sharparam Sharparam self-assigned this Nov 14, 2023
@Sharparam Sharparam added the bug label Nov 14, 2023
Copy link
Member

@Sharparam Sharparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! The drawback of testing on an empty PTR server with no other players around :)

@Sharparam Sharparam merged commit a822678 into SharpWoW:master Nov 14, 2023
1 check passed
@Sharparam Sharparam linked an issue Nov 14, 2023 that may be closed by this pull request
@Sharparam Sharparam mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent Error :(
2 participants