Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid IsGUIDInGroup call #26

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix invalid IsGUIDInGroup call #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions KillTrack.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,8 @@ function KT.Events.COMBAT_LOG_EVENT_UNFILTERED(self)

-- Perform solo/group checks
local d_id = KTT:GUIDToID(d_guid)
local firstDamage = FirstDamage[d_guid] or "<No One>"
local lastDamage = LastDamage[d_guid] or "<No One>"
local firstDamage = FirstDamage[d_guid]
local lastDamage = LastDamage[d_guid]
local firstByPlayer = firstDamage == self.PlayerGUID or firstDamage == UnitGUID("pet")
local firstByGroup = self:IsInGroup(firstDamage)
local lastByPlayer = lastDamage == self.PlayerGUID or lastDamage == UnitGUID("pet")
Expand Down Expand Up @@ -333,9 +333,9 @@ function KT:ToggleDebug()
end

function KT:IsInGroup(unit)
if not unit then return false end
if unit == self.PlayerName or unit == self.PlayerGUID then return true end
if IsGUIDInGroup(unit) then return true end
return false
return IsGUIDInGroup(unit)
end

function KT:SetThreshold(threshold)
Expand Down
Loading