fix pylint for container.py#2
Merged
SethHollandsworth merged 2 commits intoSethHollandsworth:confcom-onboardingfrom Feb 2, 2023
Merged
fix pylint for container.py#2SethHollandsworth merged 2 commits intoSethHollandsworth:confcom-onboardingfrom
SethHollandsworth merged 2 commits intoSethHollandsworth:confcom-onboardingfrom
Conversation
stevendongatmsft
force-pushed
the
confcom-onboarding
branch
from
12432f1 to
a34e4cc
Compare
| config.POLICY_FIELD_CONTAINERS_ELEMENTS_ENVS_RULE: | ||
| f"{rule[config.ACI_FIELD_CONTAINERS_ENVS_NAME]}=" | ||
| # pylint: disable=line-too-long | ||
| config.POLICY_FIELD_CONTAINERS_ELEMENTS_ENVS_RULE: f"{rule[config.ACI_FIELD_CONTAINERS_ENVS_NAME]}=" |
Owner
There was a problem hiding this comment.
does having a line break here not work? I think that would be nicer than disabling pylint
Collaborator
Author
There was a problem hiding this comment.
I have this auto format and every time when I do line break it changes back to this.
SethHollandsworth
requested changes
Feb 2, 2023
Owner
SethHollandsworth
left a comment
SethHollandsworth
left a comment
There was a problem hiding this comment.
a few things to look at, good stuff
SethHollandsworth
pushed a commit
that referenced
this pull request
Aug 14, 2024
* fix: --title --kind --custom-property parameters (#1) * feat: support yaml file in register command (#3) * fix: workspace parameter should not be required (#2) * style: fix lint issues (#6) * chore: update codeowner for apic-extension (#5) * feat: revert changes to min cli version (#4) * feat: resolve comments to CLI experience (#10) * feat: mark "apic api register" command as preview (#13) * feat: remove --terms-of-service parameter (#12) * feat: remove --workspace-name parameter (#11) * feat: support python 3.8 and 3.9 (#14) * feat: fix command descriptions (#17) * tests: add test cases for 'apic service' commands (#16) * feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19) * fix: CLI errors (#20) * fix: import error when run CLI command * fix: no workspace name error when run import specification command * feat: mark some parameters as required (#21) * feat: mark --assignments parameter required for metadata commands * doc: update sample commands * feat: mark --source-resource-ids parameter as required for import-from-apim command * doc: update description for import-from-apim command * feat: bump version to 1.0.0b5 and update changelog (#18) * build: fix ci (#22) * style: fix style warnings * test:fix test cases * fix: service update command failure (#28) * doc: fix command samples (#30) * doc: update changelog per feedback (#29) * doc: remove extra spaces in register command help message (#34) * doc: update api definition and metadata command samples (#36)
SethHollandsworth
pushed a commit
that referenced
this pull request
Jun 5, 2025
* add pester tests for k8s-extension * Adding CLI Configuration for DisableInformerCache Flag (#2) This is required for our helm charts where customers can opt to change the caching behaviour during restore. * fix testcases for nodepool image issues (#5) * update readme and version release notes (#6) * fix: simplify logic and enable correct recording rule groups for managed prom extension (#7) * remove test cases specific to fork repo --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Mayank Aggarwal <mayankagg9722@gmail.com> Co-authored-by: bragi92 <kadubey@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylint: disable=too-many-instance-attributes is added because I don't think our class design has any issues. We don't want to separate things that are supposed to be together into different classes just to accommodate pylint. Eventually imo pylint is just recommendations of what it thinks could be improved.
we can discuss pylint: disable=line-too-long. Imo it's the best way to deal with this pylint error.