Skip to content

Fix Strix quick gate fallback check matching and count logic - #315

Merged
seonghobae merged 4 commits into
masterfrom
fix-strix-fallback-check-15726068772735177747
May 30, 2026
Merged

seonghobae merged 4 commits into
masterfrom
fix-strix-fallback-check-15726068772735177747

Conversation

@seonghobae

@seonghobae seonghobae commented May 30, 2026 •

Copy link
Copy Markdown
Contributor

Fixes a bug in the Strix quick gate script where it previously relied on an inaccurate fallback models array size check which failed to trim whitespace strings and miscounted normalized elements, leading to testing regressions for the identical fallbacks scenario. The patch normalizes and correctly accounts for non-empty models, removing trailing details from the expected exit message block to exactly match CI test assertions.


PR created automatically by Jules for task 15726068772735177747 started by @seonghobae

Summary by CodeRabbit

  • Chores

    • Enhanced CI/CD script reliability with improved error handling for challenging repository configurations
    • Refined error messaging to differentiate between missing configuration and configuration mismatch scenarios
  • Tests

    • Added comprehensive test coverage for challenging repository configuration scenarios

Review Change Stack

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented May 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 38 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f552e24e-1a26-41a7-ad12-62e1ddb5dc62

📥 Commits

Reviewing files that changed from the base of the PR and between ca584b1 and 33fb2b4.

📒 Files selected for processing (2)
  • scripts/ci/strix_quick_gate.sh
  • scripts/ci/test_strix_quick_gate.sh
📝 Walkthrough

Walkthrough

The PR hardens the strix_quick_gate CI script for shallow git histories encountered in GitHub pull_request_target workflows. When merge-base-based diffs fail, the script now falls back to direct base..head diffs to still enumerate changed files. A new test helper verifies shallow-history scenarios trigger this fallback. The PR also improves error messaging when fallback models are missing or misconfigured.

Changes

PR gate shallow history and error messaging

Layer / File(s) Summary
Shallow history fallback for changed-file enumeration
scripts/ci/strix_quick_gate.sh, scripts/ci/test_strix_quick_gate.sh
PR changed-file enumeration now suppresses merge-base diff stderr and falls back to direct base..head diff when merge-base diffs fail due to shallow histories. A new test helper constructs git repos with shallow base/head fetches, runs the gate script with PR base/head SHAs, and verifies the fallback path is taken with matching output.
Fallback model configuration error messaging
scripts/ci/strix_quick_gate.sh
Fallback model error handling now counts normalized non-empty candidates after configuration normalization and emits distinct error messages: one when no fallback models are configured, another when all configured fallbacks match the primary model.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Seongho-Bae/naruon#203: Both PRs modify scripts/ci/strix_quick_gate.sh's PR-target changed-file/scoping logic—this PR adds a shallow-history merge-base→direct diff fallback while PR #203 strengthens PR_BASE_SHA/PR_HEAD_SHA validation/readability in the same changed-file enumeration function.

Poem

🐰 Through shallow seas of git's timeline,
A fallback path now helps us shine!
When merge-base fails its weary quest,
Direct diffs put our minds at rest.
Errors now speak clear and true,
Better gates for all the crew! 🎉

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main changes: fixing fallback check matching and count logic in the Strix quick gate script, which aligns with the PR objectives and summaries.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-strix-fallback-check-15726068772735177747

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 30, 2026 •

Copy link
Copy Markdown
Contributor

PR governance metadata gate is not ready for 33fb2b43ebd50d197810273cb0b469875d66c867:

  • Current-head CodeRabbit issue comment has blocking warning/failure evidence on 33fb2b4.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex[agent] 스스로 평가하고, 스스로 판단하고, 스스로 PR 후 리뷰를 검토하여 스스로 그 다음 행동을 수행하세요.

Co-authored-by: seonghobae <8172694+seonghobae@users.noreply.github.com>
@Codex

Codex AI commented May 30, 2026

Copy link
Copy Markdown
Contributor

@codex[agent] 스스로 평가하고, 스스로 판단하고, 스스로 PR 후 리뷰를 검토하여 스스로 그 다음 행동을 수행하세요.

CI에서 Strix 실패 원인이 git diff base...head가 shallow PR head 때문에 no merge base로 터지며 changed-file list를 fail-closed 하던 케이스였습니다. base..head로 안전한 fallback을 추가하고(shallow 재현 테스트 포함) ca584b1에 반영했습니다. 현재 privileged(pull_request_target) 워크플로우는 Codex 봇 푸시로 action_required 승인 상태로 보이니, PR에서 해당 워크플로우 실행 승인만 해주면 재검증 가능합니다.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 30, 2026
# Conflicts:
#	scripts/ci/strix_quick_gate.sh
@seonghobae
seonghobae temporarily deployed to fix-strix-fallback-check-15726068772735177747 - naruon PR #315 May 30, 2026 18:51 — with Render Destroyed
@seonghobae
seonghobae merged commit b62fd98 into master May 30, 2026
15 of 16 checks passed
@seonghobae
seonghobae deleted the fix-strix-fallback-check-15726068772735177747 branch May 30, 2026 18:51

This branch was successfully deployed

No deployments
fix-strix-fallback-check-15726068772735177747 - naruon PR #315 — 33fb2b43 Deployed May 30, 2026 by seonghobae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants