ci: route Strix through GitHub Models - #335
Conversation
|
Warning Review limit reached
More reviews will be available in 25 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR changes Strix scanning to default to GitHub Models (openai/openai/gpt-5), add provider_mode=github_models wiring, require a trusted LLM_API_BASE_FILE and provider-scoped github.token, and updates the CI gate script, tests, and documentation to enforce fail-closed provider routing. ChangesStrix GitHub Models Default Provider
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
|
PR governance metadata gate is not ready for |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/ci/test_strix_quick_gate.sh (1)
384-398:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winHandle the new GitHub Models success scenario in the fake dispatcher.
run_gate_casenow invokesgithub-models-model-prefix-with-api-base-succeedsat Lines 6801-6810, but thiscaseblock never matches that scenario. The self-test will drop intounknown scenario ...and fail before it verifies the GitHub Models happy path.Suggested fix
- vertex-primary-notfound-fallback-success|github-models-fallback-success|github-models-fallback-requires-api-base) + vertex-primary-notfound-fallback-success|github-models-fallback-success|github-models-fallback-requires-api-base|github-models-model-prefix-with-api-base-succeeds)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/ci/test_strix_quick_gate.sh` around lines 384 - 398, The fake dispatcher case block handling STRIX_LLM scenarios doesn't include the new "github-models-model-prefix-with-api-base-succeeds" scenario so run_gate_case falls to "unknown scenario"; update the case list (the pattern group starting with vertex-primary-notfound-fallback-success|github-models-fallback-success|...) to add a branch for github-models-model-prefix-with-api-base-succeeds that echoes the expected GitHub Models success message (matching the other GitHub success branches) and exits 0, ensuring run_gate_case will hit the happy-path for that scenario.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/ci/test_strix_quick_gate.sh`:
- Around line 6783-6817: The two failing cases
("github-models-model-prefix-requires-api-base" and
"github-models-fallback-requires-api-base") are still letting run_gate_case()
create a default LLM_API_BASE_FILE because they don't pass an explicit override;
update those run_gate_case calls to include an explicit empty string argument
for the LLM_API_BASE_FILE/override parameter (same position used in the other
calls that pass "", e.g., the 7th positional override) so run_gate_case doesn't
write the default API base file and the test exercises the
missing-LLM_API_BASE_FILE path; locate and edit the run_gate_case invocations by
name to add the empty-string override.
---
Outside diff comments:
In `@scripts/ci/test_strix_quick_gate.sh`:
- Around line 384-398: The fake dispatcher case block handling STRIX_LLM
scenarios doesn't include the new
"github-models-model-prefix-with-api-base-succeeds" scenario so run_gate_case
falls to "unknown scenario"; update the case list (the pattern group starting
with
vertex-primary-notfound-fallback-success|github-models-fallback-success|...) to
add a branch for github-models-model-prefix-with-api-base-succeeds that echoes
the expected GitHub Models success message (matching the other GitHub success
branches) and exits 0, ensuring run_gate_case will hit the happy-path for that
scenario.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1c9a2637-a7f8-41fd-9268-208ffed5cd04
📒 Files selected for processing (14)
.github/workflows/strix.ymlAGENTS.mdARCHITECTURE.mdREADME.mdbackend/tests/test_release_governance.pydocs/plans/2026-05-19-north-star-gap-closure.mddocs/plans/2026-05-27-apm-connector-operational-signals.mddocs/plans/2026-05-27-self-sent-webdav-materialization-intent.mddocs/plans/2026-05-27-strix-openai-direct-only.mddocs/plans/2026-05-29-strix-full-scan-operational-model.mddocs/plans/2026-05-29-strix-vertex-model-warning-filter.mddocs/plans/2026-05-29-strix-warning-filter-log-surface.mdscripts/ci/strix_quick_gate.shscripts/ci/test_strix_quick_gate.sh
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ARCHITECTURE.md`:
- Around line 161-165: The ARCHITECTURE.md snippet incorrectly references the
environment variable LLM_API_BASE; update the text to use LLM_API_BASE_FILE
instead so it matches the workflow behavior and the new fail-closed
contract—replace mentions of "LLM_API_BASE" with "LLM_API_BASE_FILE" in the
paragraph describing defaults (including the line that lists
STRIX_LLM=openai/openai/gpt-5 and the GitHub Models endpoint) and ensure the
wording clarifies that the workflow writes the endpoint to a trusted input file
and forwards the LLM_API_BASE_FILE rather than injecting an env var.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 02b33b5f-fb36-4641-923f-5564daf3cd84
📒 Files selected for processing (9)
.github/workflows/strix.ymlAGENTS.mdARCHITECTURE.mdREADME.mdbackend/tests/test_release_governance.pydocs/plans/2026-05-27-strix-openai-direct-only.mddocs/plans/2026-05-29-strix-full-scan-operational-model.mddocs/plans/2026-05-29-strix-vertex-model-warning-filter.mdscripts/ci/test_strix_quick_gate.sh
🚧 Files skipped from review as they are similar to previous changes (2)
- AGENTS.md
- backend/tests/test_release_governance.py
Render
Destroyed
|
Strix provider evidence for current head
Local validation for the current patch:
|
Dismiss stale CodeRabbit review after all review threads were resolved and current-head CodeRabbit status succeeded on b4f6ab1.
1 participant
Summary
Verification
Summary by CodeRabbit
New Features
Documentation
Chores / Tests