fix: Add elapsed time logging for strix fallback models - #334
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
More reviews will be available in 9 minutes and 54 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe strix quick gate now records a per-attempt start time for fallback scans, computes elapsed seconds after a successful fallback, and prints a stderr success message that includes the fallback model name and elapsed duration. Test expectations are updated to match the new message prefix ending with "in " before the variable timing text. ChangesFallback timing measurement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
|
PR governance metadata gate is not ready for
|
…6886424466314046273 # Conflicts: # scripts/ci/strix_quick_gate.sh
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/ci/test_strix_quick_gate.sh (1)
4663-4670:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winKeep asserting that a duration is actually present.
These checks now pass even if the gate logs
... inwith nothing after it, so the new elapsed-time contract is no longer covered. Switching these timing assertions to a regex-style helper that requires some non-empty suffix afterinwould keep the tests tolerant without making them this loose.Also applies to: 4699-4706, 4727-4734, 5608-5615, 6829-6837
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/ci/test_strix_quick_gate.sh` around lines 4663 - 4670, The test currently asserts the success message string ending with "in " which allows an empty duration; update the assertion used in run_gate_case so the success message requires a non-empty duration suffix (e.g., match "in " followed by one-or-more characters or digits) — replace the exact trailing "in " expectation with a regex-style check such as "in .+" (or use a helper that validates a non-empty elapsed-time token) for the case "vertex-primary-notfound-fallback-success" and apply the same change to the other occurrences you noted (lines for the other run_gate_case invocations).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/ci/test_strix_quick_gate.sh`:
- Around line 4882-4893: The test cases invoking
run_gate_case_allow_provider_signal for Gemini success paths (e.g., the
"gemini-timeout-direct-fallback-success" invocation) currently only assert fake
scanner stdout; update these cases to also assert the gate log contains the
fallback timing message (the "succeeded with fallback model ... in ..." pattern)
the same way Vertex/GitHub model cases do. Locate the three Gemini blocks (the
one starting with "gemini-timeout-direct-fallback-success" and the blocks at the
other two ranges mentioned) and add the same assertion/check that inspects the
gate stdout/log for the "succeeded with fallback model" message including the
fallback model name and timing, ensuring the pattern matches the existing
Vertex/GitHub assertions so regressions in the Gemini fallback-success timing
log are caught.
---
Outside diff comments:
In `@scripts/ci/test_strix_quick_gate.sh`:
- Around line 4663-4670: The test currently asserts the success message string
ending with "in " which allows an empty duration; update the assertion used in
run_gate_case so the success message requires a non-empty duration suffix (e.g.,
match "in " followed by one-or-more characters or digits) — replace the exact
trailing "in " expectation with a regex-style check such as "in .+" (or use a
helper that validates a non-empty elapsed-time token) for the case
"vertex-primary-notfound-fallback-success" and apply the same change to the
other occurrences you noted (lines for the other run_gate_case invocations).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0de83291-cd5f-4542-a102-5d0ce28dfbcf
📒 Files selected for processing (2)
scripts/ci/strix_quick_gate.shscripts/ci/test_strix_quick_gate.sh
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts/ci/strix_quick_gate.sh
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/ci/test_strix_quick_gate.sh (1)
4663-4670:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winKeep asserting that a duration is actually present.
These checks now pass even if the gate logs
... inwith nothing after it, so the new elapsed-time contract is no longer covered. Switching these timing assertions to a regex-style helper that requires some non-empty suffix afterinwould keep the tests tolerant without making them this loose.Also applies to: 4699-4706, 4727-4734, 5608-5615, 6829-6837
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/ci/test_strix_quick_gate.sh` around lines 4663 - 4670, The test currently asserts the success message string ending with "in " which allows an empty duration; update the assertion used in run_gate_case so the success message requires a non-empty duration suffix (e.g., match "in " followed by one-or-more characters or digits) — replace the exact trailing "in " expectation with a regex-style check such as "in .+" (or use a helper that validates a non-empty elapsed-time token) for the case "vertex-primary-notfound-fallback-success" and apply the same change to the other occurrences you noted (lines for the other run_gate_case invocations).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/ci/test_strix_quick_gate.sh`:
- Around line 4882-4893: The test cases invoking
run_gate_case_allow_provider_signal for Gemini success paths (e.g., the
"gemini-timeout-direct-fallback-success" invocation) currently only assert fake
scanner stdout; update these cases to also assert the gate log contains the
fallback timing message (the "succeeded with fallback model ... in ..." pattern)
the same way Vertex/GitHub model cases do. Locate the three Gemini blocks (the
one starting with "gemini-timeout-direct-fallback-success" and the blocks at the
other two ranges mentioned) and add the same assertion/check that inspects the
gate stdout/log for the "succeeded with fallback model" message including the
fallback model name and timing, ensuring the pattern matches the existing
Vertex/GitHub assertions so regressions in the Gemini fallback-success timing
log are caught.
---
Outside diff comments:
In `@scripts/ci/test_strix_quick_gate.sh`:
- Around line 4663-4670: The test currently asserts the success message string
ending with "in " which allows an empty duration; update the assertion used in
run_gate_case so the success message requires a non-empty duration suffix (e.g.,
match "in " followed by one-or-more characters or digits) — replace the exact
trailing "in " expectation with a regex-style check such as "in .+" (or use a
helper that validates a non-empty elapsed-time token) for the case
"vertex-primary-notfound-fallback-success" and apply the same change to the
other occurrences you noted (lines for the other run_gate_case invocations).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 0de83291-cd5f-4542-a102-5d0ce28dfbcf
📒 Files selected for processing (2)
scripts/ci/strix_quick_gate.shscripts/ci/test_strix_quick_gate.sh
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts/ci/strix_quick_gate.sh
🛑 Comments failed to post (1)
scripts/ci/test_strix_quick_gate.sh (1)
4882-4893:
⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAssert the fallback timing message in the Gemini success paths too.
These cases still only verify the fake scanner stdout, so a regression in the new fallback-success timing log for Gemini fallbacks would go unnoticed. They should assert the gate's
succeeded with fallback model ... in ...message the same way the Vertex/GitHub Models cases do.Also applies to: 4895-4907, 4908-4935
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/ci/test_strix_quick_gate.sh` around lines 4882 - 4893, The test cases invoking run_gate_case_allow_provider_signal for Gemini success paths (e.g., the "gemini-timeout-direct-fallback-success" invocation) currently only assert fake scanner stdout; update these cases to also assert the gate log contains the fallback timing message (the "succeeded with fallback model ... in ..." pattern) the same way Vertex/GitHub model cases do. Locate the three Gemini blocks (the one starting with "gemini-timeout-direct-fallback-success" and the blocks at the other two ranges mentioned) and add the same assertion/check that inspects the gate stdout/log for the "succeeded with fallback model" message including the fallback model name and timing, ensuring the pattern matches the existing Vertex/GitHub assertions so regressions in the Gemini fallback-success timing log are caught.
Dismiss stale CodeRabbit review: timing assertions were tightened in c731fb7 and current-head CodeRabbit status succeeded.
…6886424466314046273
PR created automatically by Jules for task 6886424466314046273 started by @seonghobae
Summary by CodeRabbit