Skip to content

[AgentX] MiniMax-M3.1-Flash GB300 SGLang: add more TP2 configs / [AgentX] MiniMax-M3.1-Flash GB300 SGLang:补充 TP2 配置 - #4525

Merged
Oseltamivir merged 6 commits into
mainfrom
minimaxm31flash-gb300-sglang-agentx-tp2
Oct 26, 2026
Merged

Oseltamivir merged 6 commits into
mainfrom
minimaxm31flash-gb300-sglang-agentx-tp2

Conversation

@ispobock

@ispobock ispobock commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Add TP2 points with DRAM KV offload at conc 20, 24, 28 and 36 to the existing GB300 SGLang AgentX curve, alongside the TP2 points added in #4511. They use the same image and serve flags as the existing TP2 points, with a host cache of 180 GB per rank; the recipe lives in its own file, so existing points are unchanged.

中文

为现有的 GB300 SGLang AgentX 曲线新增 conc 20、24、28、36 的 TP2 + DRAM KV offload 点,作为 #4511 中 TP2 点的补充。镜像和启动参数与现有 TP2 点相同,每个 rank 的 host cache 为 180 GB;recipe 单独成文件,现有的点不受影响。

AI model disclosure

Prepared with Claude Code using claude-opus-5-5. Reviewed by the human author before submission.

… at conc 20-36

Adds a separate TP2 key with L2 HiCache (180 GB per rank) at conc 20, 24, 28 and 36.

为 MiniMax-M3.1-Flash GB300 SGLang AgentX 新增单独的 TP2 + L2 HiCache key(每 rank 180 GB),覆盖 conc 20、24、28、36。
@ispobock ispobock added the full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) label Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps run only when the PR appends an inferencex-e2e/perf-changelog.yaml entry and carries exactly one primary label: full-sweep-fail-fast (strongly recommended; canary plus per-matrix fail-fast), full-sweep-enabled (canary; matrix jobs continue after a failure), or non-canary-full-sweep-enabled (no canary or fail-fast). The modifiers all-evals, evals-only, and agentx-fast require a primary label. On fork PRs, a maintainer applies the label. See sweep labels and reuse.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**只有当 PR 在 inferencex-e2e/perf-changelog.yaml 末尾追加了条目,并且恰好带有一个主标签时,才会运行扫描:full-sweep-fail-fast(强烈推荐;canary 加逐矩阵 fail-fast)、full-sweep-enabled(有 canary;矩阵任务在失败后继续运行)或 non-canary-full-sweep-enabled(无 canary,也无 fail-fast)。修饰标签 all-evals、evals-only 和 agentx-fast 必须与主标签一起使用。fork PR 的标签由维护者添加。参见扫描标签与复用。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment on lines +8962 to +8976
minimaxm31flash-fp4-gb300-sglang-agentic-dspark-tp2:
image: lmsysorg/sglang:dev-minimax-m31-flash@sha256:614b1509bcb729c653528d448bff9850f8977fcad9d12ba56bd6dbe3d7985e87
model: MiniMaxAI/MiniMax-M3.1-Flash
model-prefix: minimaxm31flash
runner: cluster:gb300-nv
precision: fp4
framework: sglang
multinode: false
srt-recipe-dir: minimaxm31flash/sglang/gb300-fp4-mtp
scenarios:
agentic-coding:
- dram-utilization: 0.80
search-space:
# TP2 with L2 HiCache: 180 GB per rank at conc 20-36.
- { tp: 2, spec-decoding: mtp, kv-offloading: dram, kv-offload-backend: { name: hicache }, conc-list: [20, 24, 28, 36], srt-recipe: agentic-tp2.yaml }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) The new TP2 points (conc 20-36) get their own config key and changelog entry. Readers then see a separate result set, not more points on the existing GB300 SGLang TP2 curve (conc 32-44). CONTRIBUTING.md says a PR that only adds points to an existing curve should add them to the existing key and mark the changelog entry append-only: true. That route already sweeps only the new points, so a separate key is not needed to avoid re-running the old ones. Fix: add this TP2 row to minimaxm31flash-fp4-gb300-sglang-agentic-dspark (dram-utilization 0.80 scenario) and put zip_override_tp2_hicache in agentic.yaml as another override. Then list that key in the changelog block with append-only: true.

Why this was flagged

The PR description says these points sit alongside the TP2 points from #4511. Those points live under minimaxm31flash-fp4-gb300-sglang-agentic-dspark (nvidia-master.yaml:8957, conc 32/40/44, same image, same hicache 180 GB, same mem-fraction 0.87). The diff instead adds a new key, minimaxm31flash-fp4-gb300-sglang-agentic-dspark-tp2 (nvidia-master.yaml:8962), and a new non-append-only changelog block (perf-changelog.yaml:11208). The block's stated reason is to avoid re-sweeping the existing points. CONTRIBUTING.md:172-186 describes append-only: true as the mechanism for exactly this case. It runs only the generated set difference and lets InferenceX-app extend the most recent matching curve, rather than show the partial run as a separate curve. With the separate key, conc 20-36 is published as its own config and TP2 data is split across two keys. Folding the new points into the existing key would keep TP2 as one curve.

Verification: Trigger: the PR merges with the new key and a regular (not append-only) changelog block, so its sweep is ingested as its own run. The new changelog block (perf-changelog.yaml:11208-11213) has no append-only. Because the app gets no append-only metadata, it will show this partial TP2-only run as a separate curve instead of extending the existing one.

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

@ispobock ispobock added full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) and removed full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) labels Oct 26, 2026
@Oseltamivir

Copy link
Copy Markdown
Collaborator

/use 40296110489

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

@Oseltamivir staged run 40296110489.

This run remains available across future /stage-results requests. Staging the same run ID again updates its staged data. Staging workflow

@Oseltamivir
Oseltamivir merged commit e174105 into main Oct 26, 2026
30 checks passed
@Oseltamivir
Oseltamivir deleted the minimaxm31flash-gb300-sglang-agentx-tp2 branch October 26, 2026 14:24
@github-actions

Copy link
Copy Markdown
Contributor

Ingest report — ✅ Results ingested into the production database.

Ingest workflow · Merge Ingest run · Benchmark source run

Category new duplicate skipped unmapped failed
benchmark 4 0 0 0 0
eval 0 0 0 0 0
trace 4 0 0 0 0
power 4 0 0 0 0

benchmarkFiles 4, rawBenchmarkRows 4, coveredByPerJobFiles 0, purgedPoints 0, failedRunRows 0, runStatsNew 0, runStatsDuplicate 0, evalSamplesNew 0, gpuMetricSamplesNew 45834, powerPublicationPoints 4, changelogEntriesWritten 1

Counts cover only this run. Rows: benchmark_results, eval_results, agentic rows linked to a trace, gpu_metrics series. This comment updates if the ingest is rerun.

中文

Ingest 报告 — ✅ 结果已写入 production 数据库。

上表仅统计本次运行写入的数据,各行单位依次为 benchmark_results 行、eval_results 行、已关联 trace 的 agentic 行和 gpu_metrics 序列。重新运行 ingest 时本评论会原地更新。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants