Skip to content

[AgentX] MiniMax-M3.1-Flash GB300 SGLang: add TP2 configs / [AgentX] MiniMax-M3.1-Flash GB300 SGLang:新增 TP2 配置 - #4511

Merged
edwingao28 merged 1 commit into
mainfrom
minimaxm31flash-gb300-sglang-agentx-update
Oct 26, 2026
Merged

edwingao28 merged 1 commit into
mainfrom
minimaxm31flash-gb300-sglang-agentx-update

Conversation

@ispobock

Copy link
Copy Markdown
Collaborator

Add TP2 points with DRAM KV offload at conc 32, 40 and 44 to the GB300 SGLang AgentX config, and raise mem-fraction-static to 0.87 on the DRAM KV offload points. The TP2 host cache is 180 GB per rank, inside the 385 GB allocation of a two-GPU point.

中文

为 GB300 SGLang AgentX 配置新增 conc 32、40、44 的 TP2 + DRAM KV offload 点,并把 DRAM KV offload 点的 mem-fraction-static 提高到 0.87。TP2 每个 rank 的 host cache 为 180 GB,在两卡点 385 GB 的分配额度以内。

AI model disclosure

Prepared with Claude Code using claude-opus-5-5. Reviewed by the human author before submission.

Adds TP2 with L2 HiCache at conc 32, 40 and 44, and raises mem-fraction-static to 0.87 on the DRAM-offload cells.

为 MiniMax-M3.1-Flash GB300 SGLang AgentX 新增 conc 32、40、44 的 TP2 + L2 HiCache 点,并把 DRAM offload 配置的 mem-fraction-static 提高到 0.87。
@ispobock
ispobock requested a review from a team October 25, 2026 16:24
@ispobock ispobock added the full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) label Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps run only when the PR appends an inferencex-e2e/perf-changelog.yaml entry and carries exactly one primary label: full-sweep-fail-fast (strongly recommended; canary plus per-matrix fail-fast), full-sweep-enabled (canary; matrix jobs continue after a failure), or non-canary-full-sweep-enabled (no canary or fail-fast). The modifiers all-evals, evals-only, and agentx-fast require a primary label. On fork PRs, a maintainer applies the label. See sweep labels and reuse.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**只有当 PR 在 inferencex-e2e/perf-changelog.yaml 末尾追加了条目,并且恰好带有一个主标签时,才会运行扫描:full-sweep-fail-fast(强烈推荐;canary 加逐矩阵 fail-fast)、full-sweep-enabled(有 canary;矩阵任务在失败后继续运行)或 non-canary-full-sweep-enabled(无 canary,也无 fail-fast)。修饰标签 all-evals、evals-only 和 agentx-fast 必须与主标签一起使用。fork PR 的标签由维护者添加。参见扫描标签与复用。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Beyond the inline comment, I checked three other things and none needs a fix. The pull/XXX pr-link is accepted by validate_perf_changelog.py, and existing entries already use it. The new changelog entry is a regular one, not append-only, which fits because existing hicache points change. The three zipped lists in zip_override_tp2_hicache all have length 3 and line up with conc-list [32, 40, 44].

Extended reasoning...

The change only touches benchmark config: one srt-slurm recipe, one master-config search-space row and one perf-changelog entry for minimaxm31flash-fp4-gb300-sglang-agentic-dspark. It touches no security-sensitive code. The only finding is a nit about comments, which is posted inline. This note just records the extra checks that passed.

search-space:
# Balanced TP4 with L2 HiCache: 180 GB per rank at conc 64.
- { tp: 4, spec-decoding: mtp, kv-offloading: dram, kv-offload-backend: { name: hicache }, conc-list: [64], srt-recipe: agentic.yaml }
# TP2 with L2 HiCache: 180 GB per rank at conc 32-44.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 nit (optional): The new comments label the TP2 row and override, or restate values the YAML already shows, which AGENTS.md's mandatory comment rules forbid. sweep:# TP2 with L2 HiCache Example: nvidia-master.yaml:8957 only repeats tp 2 and conc-list [32, 40, 44]. Fix: drop the label and restated values, and keep only the reason, such as why 180 GB per rank fits the two-GPU DRAM allocation.

Why this was flagged

AGENTS.md:56 bans header comments that describe a config, override or section. AGENTS.md:58 allows only technical reasons for a line and says never restate the code. The new comment at nvidia-master.yaml:8957 says what the next line already encodes: tp 2, 180 GB, conc 32-44. The new block at agentic.yaml:90-91 opens with "TP2 with L2 HiCache: two-GPU engines", which labels zip_override_tp2_hicache. It also restates gpus: 2 and the 2x CONC batch. Neighbouring overrides use the same style, but that is precedent, not an exemption. No runtime effect.

Verification: AGENTS.md:54-58 forbids "header comments describing a ... config, recipe, override, or section" and says "never restate the code". nvidia-master.yaml:8957 adds # TP2 with L2 HiCache: 180 GB per rank at conc 32-44., which labels the row and restates tp: 2 and conc-list: [32, 40, 44]. agentic.yaml:90-91 labels zip_override_tp2_hicache and restates gpus: 2. Nothing breaks at runtime.

@github-actions

Copy link
Copy Markdown
Contributor

@edwingao28

Copy link
Copy Markdown
Collaborator

/use 40211526054

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

@edwingao28 staged run 40211526054.

This run remains available across future /stage-results requests. Staging the same run ID again updates its staged data. Staging workflow

@edwingao28
edwingao28 merged commit 1c3e892 into main Oct 26, 2026
54 checks passed
@edwingao28
edwingao28 deleted the minimaxm31flash-gb300-sglang-agentx-update branch October 26, 2026 01:52
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Ingest report — ✅ Results ingested into the production database.

Ingest workflow · Merge Ingest run · Benchmark source run

Category new duplicate skipped unmapped failed
benchmark 0 13 0 0 0
eval 0 2 1 0 0
trace 0 13 0 0 0
power 0 13 0 0 0

benchmarkFiles 13, rawBenchmarkRows 13, coveredByPerJobFiles 0, purgedPoints 0, failedRunRows 0, runStatsNew 0, runStatsDuplicate 0, evalSamplesNew 0, gpuMetricSamplesNew 0, powerPublicationPoints 13, changelogEntriesWritten 1

Counts cover only this run. Rows: benchmark_results, eval_results, agentic rows linked to a trace, gpu_metrics series. This comment updates if the ingest is rerun.

中文

Ingest 报告 — ✅ 结果已写入 production 数据库。

上表仅统计本次运行写入的数据,各行单位依次为 benchmark_results 行、eval_results 行、已关联 trace 的 agentic 行和 gpu_metrics 序列。重新运行 ingest 时本评论会原地更新。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants