-
Notifications
You must be signed in to change notification settings - Fork 292
Move the DSv4 MI355X SGLang AgentX arm to sgl-dev v0.5.18 and split TP4/TP8 by concurrency #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
a3feffe
5823400
9a0194c
4a1f75d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1722,12 +1722,17 @@ glm5.2-fp4-mi355x-atom-agentic-mtp: | |
| # SGLang AgentX coverage removed in de493d859 (PR #2531, which deleted the | ||
| # spec-none dsv4-fp4-mi355x-sglang-agentic-hicache key and its script) so the | ||
| # aggregated SGLang path is comparable with dsv4-fp4-mi355x-vllm-agentic-mtp | ||
| # and dsv4-fp4-mi355x-sglang-disagg-agentic-hicache-mtp. The image matches the | ||
| # already-green disagg AgentX entry. Pure TP8 only: DSA + dp-attention hangs a | ||
| # collective under long-context prefill, so no DEP arm ships until that path is | ||
| # validated. conc 16 appears on both arms to isolate the host KV tier's gain. | ||
| # and dsv4-fp4-mi355x-sglang-disagg-agentic-hicache-mtp. The image is the | ||
| # sgl-dev v0.5.18 build, which carries the DSv4 kernel fusions this key enables | ||
| # via SGLANG_OPT_*. Tensor-parallel only: DSA + dp-attention hangs a collective | ||
| # under long-context prefill, so no DEP arm ships until that path is validated. | ||
| # TP4 owns the low-concurrency end, where halving the GPUs per replica raises | ||
| # throughput per GPU, and TP8 picks up from conc 16; conc 16 appears on both TP8 | ||
| # arms to isolate the host KV tier's gain. TP4 doubles per-rank weights, leaving | ||
| # far less room for KV, which is why it stops at conc 10 and carries no host | ||
| # tier. | ||
| dsv4-fp4-mi355x-sglang-agentic-mtp: | ||
| image: lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260813 | ||
| image: lmsysorg/sglang-rocm:v0.5.17-rocm720-mi35x-20260822 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Invented nonexistent image tagHigh Severity The image was rewritten from the validated Reviewed by Cursor Bugbot for commit 4a1f75d. Configure here. |
||
| model: deepseek-ai/DeepSeek-V4-Pro | ||
| model-prefix: dsv4 | ||
| runner: cluster:mi355x-amds | ||
|
|
@@ -1738,5 +1743,6 @@ dsv4-fp4-mi355x-sglang-agentic-mtp: | |
| agentic-coding: | ||
| - dram-utilization: 0.80 | ||
| search-space: | ||
| - { tp: 8, ep: 1, dp-attn: false, kv-offloading: none, conc-list: [1, 2, 4, 8, 16], spec-decoding: mtp } | ||
| - { tp: 4, ep: 1, dp-attn: false, kv-offloading: none, conc-list: [1, 2, 4, 8, 10], spec-decoding: mtp } | ||
| - { tp: 8, ep: 1, dp-attn: false, kv-offloading: none, conc-list: [16], spec-decoding: mtp } | ||
| - { tp: 8, ep: 1, dp-attn: false, kv-offloading: dram, kv-offload-backend: { name: hicache }, conc-list: [16, 32, 48], spec-decoding: mtp } | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing aiter master switch
Medium Severity
SGLANG_OPT_USE_AITER_BATCHED_GEMMis enabled to route the DSv4 MLA absorb GEMM through aiter, butSGLANG_USE_AITERis never set. Sibling MI355X recipes and the multi-node DSv4 env export that master switch; without it the batched-GEMM path typically stays inactive, so the advertised fusion does not take effect.Reviewed by Cursor Bugbot for commit 9a0194c. Configure here.