Repository navigation
[Power] feat: extend dcgm energy lanes to gb dsv4/qwen3.5 fp4 / 扩展 dcgm 能耗采集到 gb dsv4 与 qwen3.5 fp4 - #2507
Merged
Claude / Claude Code Review
completed
Aug 6, 2026 in 8m 16s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | runners/launch_gb200-nv.sh:308-314 |
AGENTS.md power-lane doc now stale after fp8-only gate removed |
Annotations
Check warning on line 314 in runners/launch_gb200-nv.sh
claude / Claude Code Review
AGENTS.md power-lane doc now stale after fp8-only gate removed
AGENTS.md:152 still says dcgm-power lanes are validated for `PRECISION=fp8` only, but this PR replaces that fp8 fail-fast in both `launch_gb200-nv.sh` and `launch_gb300-nv.sh` with a `FRAMEWORK=dynamo-sglang` gate and ships six new fp4 dcgm-power recipes (5 DSV4 fp4 + 1 qwen3.5 fp4). That doc sentence is now factually false and should be updated in this PR to describe the new framework-based gate.
Loading