[Power] feat: extend dcgm energy lanes to gb dsv4/qwen3.5 fp4 / 扩展 dcgm 能耗采集到 gb dsv4 与 qwen3.5 fp4 - #2507
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
…gm 能耗采集到 gb dsv4 与 qwen3.5 fp4 recipe 侧:5 个 DSV4 8k1k 点位与 qwen3.5-fp4 gb300 lowlat 配方加 telemetry 块(gb300 用 19401 端口)。launcher 侧:gb200 dsv4 分支在 power 时改克隆 pinned producer;gb300 新增仅 power 生效的 dsv4 路由(非 power 路径保持原样);precision 门换成 framework 门(dynamo-sglang 之外仍然快速失败)。契约测试同步:recipe 白名单 8 项 + 逐配方 telemetry 断言。
8e2ca1c to
3ad142d
Compare
|
Claude finished @edwingao28's task in 4m 58s —— View job Review of PR #2507
Found 1 blocking issue (inline comment on Everything else checked out clean:
Note: this sandbox's permissions blocked running |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ad142d752
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… lanes / 为 node-local fp4 能耗 lane 加 no-preflight 与 numa1 模型路径 两个 canary 都死在同一处:模型在 compute-node 本地盘(gb200 /mnt/numa1、gb300 /scratch),login 侧 runner stat 不到,srtctl preflight 必然误报。沿用 repo 已有豁免机制(agentic/glm5.1/qwen3.5-fp8 同款),范围限定 USES_DCGM_POWER=1;gb200 power lane 的 MODEL_PATH 指向 agentic 与 llm-d 实测在用的 /mnt/numa1 检查点,共享的 lustre 路径保持不动。
…dia-master 中已失效的 gb300 dsv4 镜像 pin launcher 的 import_squash 用的是 master yaml 的 image 字段,0520 nightly 已被 Docker Hub GC;与配方一致换成仍在线的 0721(B300 DSV4 家族同款)。仅动 dsv4-fp4-gb300-dynamo-sglang 一个 key,mtp key 不碰。
中文:将 GB200/GB300 FP4 功耗采集分支同步到最新 main,并保留已验证的镜像与 no-preflight 规则。
|
Refreshed on current main and finished the loose ends:
Contract suites: 20/20 passing. |
Extends the dcgm-power measurement lanes (built in #2323/#2437/#2456) to the fp4 recipes the scale campaign needs: five DSV4 8k1k Pareto points (gb200 c1/c512/c256, gb300 c1/c1024) and the qwen3.5-fp4 gb300 low-latency ladder. Recipes opt in through the same telemetry block the fp8 lanes use; gb300 recipes take port 19401 for the known cluster-exporter collision.
Launcher changes, kept surgical:
dynamo-sglang && dsv4branch clones the pinned producer when the resolved recipe carries an enabled dcgm-power block, and keeps its currentNVIDIA/srt-slurm:mainclone otherwise. The recipe overlay is unchanged.dynamo-sglangonly; any other framework still exits early instead of silently cloning a diverging ref (aflowers branch / sa-submission).Safety checks done before opening:
6fc1bed) config loader — none of them use sa-submission-only schema fields (warmup_req_rate, spread placement, request-plane options).sa_bench_tokenizers.sglang_deepseek_v4(used by the gb300 DSV4 recipes) is present at the pin.mainlineage the pin descends from; the qwen3.5 fp4 recipe pins dynamo by version (pip path), which the pin supports.bash -n.Scope: the config keys already exist; dispatches for validation use exact-key test-config. One master-yaml line changes: the
dsv4-fp4-gb300-dynamo-sglangimage pin, whose nightly (20260520) has been garbage-collected from Docker Hub — bumped to the live20260721nightly the B300 DSV4 family already runs (recipe container fields bumped to match). Heads-up for maintainers: several other multinode pins (gb200DSV420260528, gb300 qwen3.5-fp420260624) are also gone from the Hub and currently survive only on per-cluster squash caches.Canary validation (both from this branch,
require-power=true):20260721image (fresh arm64 pull, no cache).The first canary attempt failed at srtctl preflight ("model alias resolved to a path unavailable") and produced the second commit: these fp4 models live on compute-node-local NVMe (gb200
/mnt/numa1, gb300/scratch), which the login-side runner cannot stat — the same situation the existing agentic/glm5.1/qwen3.5-fp8--no-preflightexemptions cover. The power lanes join that list, scoped toUSES_DCGM_POWER=1; the gb200 power lane also pointsMODEL_PATHat the/mnt/numa1checkpoint the agentic path already loads from (the shared lustre alias stays untouched for the external-cluster staging).中文:把能耗采集扩展到 scale campaign 需要的 fp4 配方(DSV4 五个点位 + qwen3.5-fp4 gb300 低延迟梯子)。launcher 改动保持外科式:gb200 dsv4 分支仅在 power 时改克隆 pinned producer;gb300 新增仅 power 生效的 dsv4 路由,非 power 路径逐字节不变;fp8 精度门换成 framework 门。六个配方已在 pin 的 loader 下解析通过,契约测试 16/16 绿。canary 链接补充后转正式 review。