Skip to content
81 changes: 81 additions & 0 deletions configs/amd-master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1224,6 +1224,87 @@
- "DECODE_NODES=1"
- "DECODE_MTP_SIZE=0"

# MTP variant of dsv4-fp4-mi355x-sglang-disagg (base run 29821778206). Mirrors
# the base disagg search space and topologies exactly (same 20260701 image,
# mori KV transfer + MoE a2a, sglang-router --pd-disaggregation) and enables
# DeepSeek-V4 built-in MTP on the decode side via spec-decoding: mtp — the same
# enablement path as dsr1-fp8-mi355x-sglang-disagg-mtp. Following that
# precedent, DECODE_MTP_SIZE=2 on the pure-TP8 (bottom-of-curve) arm and
# DECODE_MTP_SIZE=1 on the DEP8 (top-of-curve) arms. The dsv4 ROCm MTP
# CUDA-graph fix (sgl-project/sglang#26383, merged 2026-05-27) is already
# present in the pinned 20260701 nightly, so no image bump is needed.
dsv4-fp4-mi355x-sglang-disagg-mtp:
image: lmsysorg/sglang-rocm:v0.5.14-rocm720-mi35x-20260701
model: deepseek-ai/DeepSeek-V4-Pro
model-prefix: dsv4
runner: mi355x-disagg
precision: fp4
framework: sglang-disagg
router: { name: sglang-router, version: "0.3.2" }
kv-p2p-transfer: mori
multinode: true
disagg: true
scenarios:
fixed-seq-len:
- isl: 8192
osl: 1024
search-space:
# MTP configurations
# 1P1D pure TP8 (mori KV transfer)
- spec-decoding: "mtp"
conc-list: [ 1, 2, 4, 8, 16, 32, 64, 128 ]
prefill:

Check failure on line 1256 in configs/amd-master.yaml

View check run for this annotation

Claude / Claude Code Review

dsv4 disagg MTP config missing --speculative-algorithm (DeepSeek-V4-Pro-DI has no mtp_flags)

The new `dsv4-fp4-mi355x-sglang-disagg-mtp` config sets `DECODE_MTP_SIZE=1/2` with `spec-decoding: mtp`, but `DeepSeek-V4-Pro-DI` in `models.yaml` has no `mtp_flags` key (unlike the DeepSeek-R1 entries), so `server_sglang.sh` builds the decode server's MTP config with only `--speculative-num-steps`/`--speculative-num-draft-tokens` and no `--speculative-algorithm`. Every arm of this new search space will either fail to start the decode server or silently run without MTP enabled — fix by adding `m
Comment thread
Oseltamivir marked this conversation as resolved.
num-worker: 1
tp: 8
ep: 1
dp-attn: false
additional-settings:
- "PREFILL_NODES=1"
decode:
num-worker: 1
tp: 8
ep: 1
dp-attn: false
additional-settings:
- "DECODE_NODES=1"
- "DECODE_MTP_SIZE=2"
# 1P1D DEP8 (mori KV transfer + mori MoE a2a, dp-attention)
- spec-decoding: "mtp"
conc-list: [ 256 ]
prefill:
num-worker: 1
tp: 8
ep: 8
dp-attn: true
additional-settings:
- "PREFILL_NODES=1"
decode:
num-worker: 1
tp: 8
ep: 8
dp-attn: true
additional-settings:
- "DECODE_NODES=1"
- "DECODE_MTP_SIZE=1"

- spec-decoding: "mtp"
conc-list: [ 512 ]
prefill:
num-worker: 1
tp: 8
ep: 8
dp-attn: true
additional-settings:
- "PREFILL_NODES=1"
decode:
num-worker: 1
tp: 8
ep: 8
dp-attn: true
additional-settings:
- "DECODE_NODES=1"
- "DECODE_MTP_SIZE=1"


dsv4-fp4-mi355x-sglang:
image: lmsysorg/sglang-rocm:v0.5.14-rocm720-mi35x-20260706
Expand Down
9 changes: 9 additions & 0 deletions perf-changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5060,3 +5060,12 @@
- "Re-pin VLLM_ROUTER_IMAGE to vllm/vllm-router:nightly-20260716-1fbcde7 (previous nightly-20260629-e667ebb was garbage-collected from Docker Hub)"
- "Exclude known-bad nodes mia1-p01-g09,g14 from the disagg node pool"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/2301

- config-keys:
- dsv4-fp4-mi355x-sglang-disagg-mtp
description:
- "Add MTP variant of dsv4-fp4-mi355x-sglang-disagg (new config-key dsv4-fp4-mi355x-sglang-disagg-mtp)"
- "Clones the base disagg search space and topologies exactly (same image lmsysorg/sglang-rocm:v0.5.14-rocm720-mi35x-20260701, mori KV transfer + MoE a2a, sglang-router --pd-disaggregation on :30000); enables DeepSeek-V4 built-in MTP on decode via spec-decoding: mtp, same enablement path as dsr1-fp8-mi355x-sglang-disagg-mtp"
- "Topologies: 1P1D pure-TP8/EP1 (conc 1-128) at DECODE_MTP_SIZE=2; 1P1D DEP8 (TP8/EP8 + dp-attention) conc 256 and conc 512 at DECODE_MTP_SIZE=1"
- "No launcher change: the disagg path already threads DECODE_MTP_SIZE (base arms use 0). MTP CUDA-graph fix sgl-project/sglang#26383 (merged 2026-05-27) is present in the pinned 20260701 nightly"
pr-link: XXX

Check warning on line 5071 in perf-changelog.yaml

View check run for this annotation

Claude / Claude Code Review

PR title missing required Chinese translation

AGENTS.md mandates PR titles be bilingual (`<English title> / <中文标题>`, AGENTS.md lines 7-9), but this PR's title, `[AMD][dsv4] Add MTP variant of dsv4-fp4-mi355x-sglang-disagg`, has no Chinese portion. Please update the title to include a Simplified Chinese translation; also note the `pr-link` field in the new perf-changelog.yaml entry (lines 5063-5071) is still a placeholder `XXX` and needs to be filled in with the actual PR URL before merge.
Comment thread
Oseltamivir marked this conversation as resolved.
Outdated
Loading