Repository navigation
[AMD][dsv4] Add MTP variant of dsv4-fp4-mi355x-sglang-disagg - #2305
Merged
Merged
Claude / Claude Code Review
completed
Jul 23, 2026 in 14m 58s
Code review found 1 important issue
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | configs/amd-master.yaml:1227-1256 |
dsv4 disagg MTP config missing --speculative-algorithm (DeepSeek-V4-Pro-DI has no mtp_flags) |
| 🟡 Nit | perf-changelog.yaml:5063-5071 |
PR title missing required Chinese translation |
Annotations
Check failure on line 1256 in configs/amd-master.yaml
claude / Claude Code Review
dsv4 disagg MTP config missing --speculative-algorithm (DeepSeek-V4-Pro-DI has no mtp_flags)
The new `dsv4-fp4-mi355x-sglang-disagg-mtp` config sets `DECODE_MTP_SIZE=1/2` with `spec-decoding: mtp`, but `DeepSeek-V4-Pro-DI` in `models.yaml` has no `mtp_flags` key (unlike the DeepSeek-R1 entries), so `server_sglang.sh` builds the decode server's MTP config with only `--speculative-num-steps`/`--speculative-num-draft-tokens` and no `--speculative-algorithm`. Every arm of this new search space will either fail to start the decode server or silently run without MTP enabled — fix by adding `m
Check warning on line 5071 in perf-changelog.yaml
claude / Claude Code Review
PR title missing required Chinese translation
AGENTS.md mandates PR titles be bilingual (`<English title> / <中文标题>`, AGENTS.md lines 7-9), but this PR's title, `[AMD][dsv4] Add MTP variant of dsv4-fp4-mi355x-sglang-disagg`, has no Chinese portion. Please update the title to include a Simplified Chinese translation; also note the `pr-link` field in the new perf-changelog.yaml entry (lines 5063-5071) is still a placeholder `XXX` and needs to be filled in with the actual PR URL before merge.
Loading