Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@

if [[ "$MODEL" != /* ]]; then hf download "$MODEL"; fi

export SGLANG_USE_AITER=1
export SGLANG_USE_AITER_UNIFIED_ATTN=1
export AITER_FLYDSL_FORCE=1
export SGLANG_MAMBA_SSM_DTYPE=bfloat16

Check failure on line 23 in benchmarks/single_node/fixed_seq_len/qwen3.5_fp4_mi355x.sh

View check run for this annotation

Claude / Claude Code Review

SGLANG_MAMBA_SSM_DTYPE env var likely ignored by sglang; use --mamba-ssm-dtype CLI flag instead

Both `qwen3.5_fp4_mi355x.sh` and `qwen3.5_fp4_mi355x_mtp.sh` set `export SGLANG_MAMBA_SSM_DTYPE=bfloat16` instead of passing `--mamba-ssm-dtype bfloat16` to `sglang.launch_server`, which is how every other Qwen3.5 hybrid-Mamba sglang recipe in this repo configures the SSM cache dtype. If sglang does not read that env var (there is no other evidence in this repo that it does), the export is a silent no-op and the benchmark runs with the default SSM cache dtype instead of the intended bfloat16.
Comment thread
yichiche marked this conversation as resolved.

SERVER_LOG=/workspace/server.log
MEM_FRAC_STATIC=${MEM_FRAC_STATIC:-0.8}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ hf download "$MODEL"
export SGLANG_USE_AITER=1
export SGLANG_USE_AITER_UNIFIED_ATTN=1
export AITER_FLYDSL_FORCE=1
export SGLANG_MAMBA_SSM_DTYPE=bfloat16

SERVER_LOG=/workspace/server.log
MEM_FRAC_STATIC=${MEM_FRAC_STATIC:-0.8}
Expand Down
4 changes: 2 additions & 2 deletions configs/amd-master.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@
- "DECODE_MTP_SIZE=0"

qwen3.5-fp4-mi355x-sglang:
image: lmsysorg/sglang-rocm:v0.5.13-rocm720-mi35x-20260612
image: lmsysorg/sglang-rocm:v0.5.15-rocm720-mi35x-20260713

Check failure on line 418 in configs/amd-master.yaml

View check run for this annotation

Claude / Claude Code Review

Missing perf-changelog.yaml entry for image bump + new env var

This PR bumps the sglang-rocm image for `qwen3.5-fp4-mi355x-sglang` and `qwen3.5-fp4-mi355x-sglang-mtp` (v0.5.13 → v0.5.15) and adds `SGLANG_MAMBA_SSM_DTYPE=bfloat16` to both single-node scripts, but does not append a `perf-changelog.yaml` entry. Per AGENTS.md this is required to trigger the benchmark sweep on merge to main — please add an entry (config-keys, description, pr-link) following the pattern used by the immediately preceding sibling PRs (#2197, #2198).
Comment thread
yichiche marked this conversation as resolved.
model: amd/Qwen3.5-397B-A17B-MXFP4
model-prefix: qwen3.5
runner: mi355x
Expand Down Expand Up @@ -457,7 +457,7 @@
- { tp: 4, conc-start: 4, conc-end: 16 }

qwen3.5-fp4-mi355x-sglang-mtp:
image: lmsysorg/sglang-rocm:v0.5.13-rocm720-mi35x-20260612
image: lmsysorg/sglang-rocm:v0.5.15-rocm720-mi35x-20260713
model: amd/Qwen3.5-397B-A17B-MXFP4
model-prefix: qwen3.5
runner: mi355x
Expand Down