Repository navigation
[AMD][MI35X] Qwen3.5-fp4 SGLang single-node benchmark env update - #2201
Merged
Merged
Claude / Claude Code Review
completed
Jul 14, 2026 in 10m 2s
Code review found 2 important issues
Found 4 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 2 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | benchmarks/single_node/fixed_seq_len/qwen3.5_fp4_mi355x.sh:20-23 |
SGLANG_MAMBA_SSM_DTYPE env var likely ignored by sglang; use --mamba-ssm-dtype CLI flag instead |
| 🔴 Important | configs/amd-master.yaml:418 |
Missing perf-changelog.yaml entry for image bump + new env var |
Annotations
Check failure on line 23 in benchmarks/single_node/fixed_seq_len/qwen3.5_fp4_mi355x.sh
claude / Claude Code Review
SGLANG_MAMBA_SSM_DTYPE env var likely ignored by sglang; use --mamba-ssm-dtype CLI flag instead
Both `qwen3.5_fp4_mi355x.sh` and `qwen3.5_fp4_mi355x_mtp.sh` set `export SGLANG_MAMBA_SSM_DTYPE=bfloat16` instead of passing `--mamba-ssm-dtype bfloat16` to `sglang.launch_server`, which is how every other Qwen3.5 hybrid-Mamba sglang recipe in this repo configures the SSM cache dtype. If sglang does not read that env var (there is no other evidence in this repo that it does), the export is a silent no-op and the benchmark runs with the default SSM cache dtype instead of the intended bfloat16.
Check failure on line 418 in configs/amd-master.yaml
claude / Claude Code Review
Missing perf-changelog.yaml entry for image bump + new env var
This PR bumps the sglang-rocm image for `qwen3.5-fp4-mi355x-sglang` and `qwen3.5-fp4-mi355x-sglang-mtp` (v0.5.13 → v0.5.15) and adds `SGLANG_MAMBA_SSM_DTYPE=bfloat16` to both single-node scripts, but does not append a `perf-changelog.yaml` entry. Per AGENTS.md this is required to trigger the benchmark sweep on merge to main — please add an entry (config-keys, description, pr-link) following the pattern used by the immediately preceding sibling PRs (#2197, #2198).
Loading