Skip to content

[dotnet] [bidi] Fix various missing fields in DTO #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 2 commits into from
Aug 28, 2026
Merged

[dotnet] [bidi] Fix various missing fields in DTO #17961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7391f5
[dotnet] [bidi] Fix various missing fields in DTO
nvborisenko Aug 28, 2026
2589bcc
Merge branch 'trunk' into bidi-missing-fields
nvborisenko Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions dotnet/src/webdriver/BiDi/BrowsingContext/DownloadEndEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,25 +26,31 @@ namespace OpenQA.Selenium.BiDi.BrowsingContext;

[JsonConverter(typeof(DownloadEndEventArgsConverter))]
public abstract record DownloadEndEventArgs(
BrowsingContext Context)
: EventArgs;
BrowsingContext Context,
Navigation? Navigation,
[property: JsonConverter(typeof(DateTimeOffsetConverter))] DateTimeOffset Timestamp,
string Url,
Browser.UserContext? UserContext)
: EventArgs, IBaseNavigationInfo;

public sealed record DownloadCanceledEventArgs(
Download Download,
BrowsingContext Context,
Navigation? Navigation,
[property: JsonConverter(typeof(DateTimeOffsetConverter))] DateTimeOffset Timestamp,
string Url)
: DownloadEndEventArgs(Context), IBaseNavigationInfo;
DateTimeOffset Timestamp,
string Url,
Browser.UserContext? UserContext)
: DownloadEndEventArgs(Context, Navigation, Timestamp, Url, UserContext);

public sealed record DownloadCompleteEventArgs(
Download Download,
string? Filepath,
BrowsingContext Context,
Navigation? Navigation,
[property: JsonConverter(typeof(DateTimeOffsetConverter))] DateTimeOffset Timestamp,
string Url)
: DownloadEndEventArgs(Context), IBaseNavigationInfo;
DateTimeOffset Timestamp,
string Url,
Browser.UserContext? UserContext)
: DownloadEndEventArgs(Context, Navigation, Timestamp, Url, UserContext);

internal class DownloadEndEventArgsConverter : JsonConverter<DownloadEndEventArgs>
{
Expand Down
3 changes: 2 additions & 1 deletion dotnet/src/webdriver/BiDi/BrowsingContext/DownloadWillBeginEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,6 @@ public sealed record DownloadWillBeginEventArgs(
BrowsingContext Context,
Navigation? Navigation,
[property: JsonConverter(typeof(DateTimeOffsetConverter))] DateTimeOffset Timestamp,
string Url)
string Url,
Browser.UserContext? UserContext)
: EventArgs, IBaseNavigationInfo;
2 changes: 2 additions & 0 deletions dotnet/src/webdriver/BiDi/BrowsingContext/IBaseNavigationInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,6 @@ public interface IBaseNavigationInfo
DateTimeOffset Timestamp { get; }

string Url { get; }

Browser.UserContext? UserContext { get; }
}
1 change: 1 addition & 0 deletions dotnet/src/webdriver/BiDi/Script/Evaluate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public sealed record EvaluateResultException(
public sealed record ExceptionDetails(
long ColumnNumber,
long LineNumber,
RemoteValue Exception,
StackTrace StackTrace,
string Text);

Expand Down