Skip to content

[dotnet] [bidi] Fix various missing fields in DTO - #17961

Merged
nvborisenko merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:bidi-missing-fields
Aug 28, 2026
Merged

[dotnet] [bidi] Fix various missing fields in DTO#17961
nvborisenko merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:bidi-missing-fields

Conversation

@nvborisenko

Copy link
Copy Markdown
Member

💥 What does this PR do?

This pull request updates several event argument records and interfaces in the BiDi BrowsingContext and Script modules to improve consistency and add support for user context and exception details. The main changes involve extending event argument records to include the UserContext property, updating the IBaseNavigationInfo interface, and enhancing exception details.

Event Argument and Interface Updates:

  • Added the Browser.UserContext? UserContext property to the DownloadEndEventArgs, DownloadCanceledEventArgs, DownloadCompleteEventArgs, and DownloadWillBeginEventArgs records to provide additional context about the user associated with the event. [1] [2]
  • Updated the IBaseNavigationInfo interface to include the new UserContext property for consistency across navigation-related events.

Exception Details Enhancement:

  • Added the RemoteValue Exception property to the ExceptionDetails record in Evaluate.cs to capture more detailed information about script evaluation exceptions.

🔄 Types of changes

  • New feature (non-breaking change which adds functionality and tests!)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added the C-dotnet .NET Bindings label Aug 28, 2026
@nvborisenko
nvborisenko merged commit 3e81234 into SeleniumHQ:trunk Aug 28, 2026
23 checks passed
@nvborisenko
nvborisenko deleted the bidi-missing-fields branch August 28, 2026 16:31
This was referenced Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants