[dotnet] [bidi] Fix various missing fields in DTO - #17961
Merged
Conversation
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
This pull request updates several event argument records and interfaces in the BiDi BrowsingContext and Script modules to improve consistency and add support for user context and exception details. The main changes involve extending event argument records to include the
UserContextproperty, updating theIBaseNavigationInfointerface, and enhancing exception details.Event Argument and Interface Updates:
Browser.UserContext? UserContextproperty to theDownloadEndEventArgs,DownloadCanceledEventArgs,DownloadCompleteEventArgs, andDownloadWillBeginEventArgsrecords to provide additional context about the user associated with the event. [1] [2]IBaseNavigationInfointerface to include the newUserContextproperty for consistency across navigation-related events.Exception Details Enhancement:
RemoteValue Exceptionproperty to theExceptionDetailsrecord inEvaluate.csto capture more detailed information about script evaluation exceptions.🔄 Types of changes