Skip to content

[dotnet] [bidi] Fix mismatch of proxy json property names #17960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 2 commits into from
Aug 28, 2026
Merged

[dotnet] [bidi] Fix mismatch of proxy json property names #17960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4264bac
[dotnet] [bidi] Fix mismatch of proxy json property names
nvborisenko Aug 28, 2026
44c33d7
Merge branch 'trunk' into bidi-fix-proxy
nvborisenko Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/BiDi/Session/CapabilityRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public sealed record CapabilityRequest

public string? PlatformName { get; init; }

public ProxyConfiguration? ProxyConfiguration { get; init; }
public ProxyConfiguration? Proxy { get; init; }

public UserPromptHandler? UnhandledPromptBehavior { get; init; }
}
6 changes: 3 additions & 3 deletions dotnet/src/webdriver/BiDi/Session/ProxyConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@
namespace OpenQA.Selenium.BiDi.Session;

[JsonPolymorphic(TypeDiscriminatorPropertyName = "proxyType")]
[JsonDerivedType(typeof(AutoDetectProxyConfiguration), "autodetect")]
[JsonDerivedType(typeof(AutodetectProxyConfiguration), "autodetect")]
[JsonDerivedType(typeof(DirectProxyConfiguration), "direct")]
[JsonDerivedType(typeof(ManualProxyConfiguration), "manual")]
[JsonDerivedType(typeof(PacProxyConfiguration), "pac")]
[JsonDerivedType(typeof(SystemProxyConfiguration), "system")]
public abstract record ProxyConfiguration;

public sealed record AutoDetectProxyConfiguration : ProxyConfiguration;
public sealed record AutodetectProxyConfiguration : ProxyConfiguration;

public sealed record DirectProxyConfiguration : ProxyConfiguration;

Expand All @@ -46,7 +46,7 @@ public sealed record ManualProxyConfiguration : ProxyConfiguration, ISocksProxyC
public ImmutableArray<string>? NoProxy { get; init; }
}

public sealed record PacProxyConfiguration(string ProxyAutoConfigUrl) : ProxyConfiguration;
public sealed record PacProxyConfiguration(string ProxyAutoconfigUrl) : ProxyConfiguration;

public sealed record SystemProxyConfiguration : ProxyConfiguration;

Expand Down