Skip to content

[dotnet] [bidi] Fix mismatch of proxy json property names - #17960

Merged
nvborisenko merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:bidi-fix-proxy
Aug 28, 2026
Merged

[dotnet] [bidi] Fix mismatch of proxy json property names#17960
nvborisenko merged 2 commits into
SeleniumHQ:trunkfrom
nvborisenko:bidi-fix-proxy

Conversation

@nvborisenko

Copy link
Copy Markdown
Member

Align with the spec.

💥 What does this PR do?

This pull request makes several naming consistency improvements to the BiDi session proxy configuration classes and properties. The main focus is on standardizing class and property names to match expected conventions.

Proxy configuration naming updates:

  • Renamed the ProxyConfiguration property in CapabilityRequest to Proxy for clarity and consistency (dotnet/src/webdriver/BiDi/Session/CapabilityRequest.cs).
  • Renamed the class AutoDetectProxyConfiguration to AutodetectProxyConfiguration and updated its usage in the [JsonDerivedType] attribute to match the new name (dotnet/src/webdriver/BiDi/Session/ProxyConfiguration.cs).
  • Renamed the constructor parameter in PacProxyConfiguration from ProxyAutoConfigUrl to ProxyAutoconfigUrl for naming consistency (dotnet/src/webdriver/BiDi/Session/ProxyConfiguration.cs).

🔄 Types of changes

  • Bug fix (backwards compatible)

@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@selenium-ci selenium-ci added the C-dotnet .NET Bindings label Aug 28, 2026
@nvborisenko
nvborisenko merged commit df96a50 into SeleniumHQ:trunk Aug 28, 2026
23 checks passed
@nvborisenko
nvborisenko deleted the bidi-fix-proxy branch August 28, 2026 16:31
This was referenced Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-dotnet .NET Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants