-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Schema HTTPS in Distributor, SessionQueue, SessionMap #13413
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13413 +/- ##
=======================================
Coverage 58.07% 58.07%
=======================================
Files 88 88
Lines 5340 5340
Branches 224 224
=======================================
Hits 3101 3101
Misses 2015 2015
Partials 224 224 ☔ View full report in Codecov by Sentry. |
This LGTM. However, @diemol Can you help confirm? Thank you! |
@pujagani, thanks for your review! By the way, after this change |
Ah ok, I found it, I enabled the registration secret. The same secret I already set for for Distributor, Router and Node. Let me check further what can be wrong |
Above issue only problem when missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I think we can refactor some code to reuse it better.
java/src/org/openqa/selenium/grid/distributor/config/DistributorOptions.java
Outdated
Show resolved
Hide resolved
java/src/org/openqa/selenium/grid/sessionmap/config/SessionMapOptions.java
Outdated
Show resolved
Hide resolved
java/src/org/openqa/selenium/grid/sessionqueue/config/NewSessionQueueOptions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Viet Nguyen Duc <[email protected]>
cbebb7e
to
10d83bb
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
@diemol, thank you. Before I faced issues with symbols not found etc. However, it is simple only with bazel deps import 👍 Have a chance to familiarize with bazel. Code looks clean now. Can you review one more round. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @VietND96!
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
[java] Schema HTTPS in Distributor, SessionQueue, SessionMap
Motivation and Context
Downstream created a feat to enable HTTPS for Grid SeleniumHQ/docker-selenium#2080
However, when testing with distributed components, Router could not up due to wait for
/readyz
gets ready. This check requires Distributor, SessionMap, SessionQueue/readyz
however there are hardcodedhttp
in the schema when constructing the URL of those components. Added a check to switch the schema properlyTypes of changes
Checklist